Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

New formula for OpenJade #14026

Closed
wants to merge 3 commits into from

6 participants

@theirix

Formula for OpenJade (http://openjade.sourceforge.net), DSSSL
SGML processor. Port is derived from MacPorts, uses all
provided patches and one more patch about missing .la file.
Port requires LLVM compiler, open-sp built with LLVM and
recently added xmlcatmgr.

@michaelpq

+1, this is very helpful when working on SGML documentation, particularly PostgreSQL.

@adamv
Owner

A little uncomfortable about adding something that requires LLVM, as Clang is Apple's compiler going forward.

@theirix

Unfortunately my previous efforts to update open-jade to compile with clang failed - very old code. Anyway I'll try to do this again.

@adamv
Owner

Please squash to a single commit for review, thanks.

@adamv
Owner

Can some other maintainers review this? I'm uncomfortable with the rescue blocks here.

theirix and others added some commits
@theirix theirix New formula for OpenJade
Formula for OpenJade (http://openjade.sourceforge.net), DSSSL
SGML processor. Port is derived from MacPorts, uses all
provided patches and one more patch about missing .la file.
0ddc571
@theirix theirix Fixed patch order, clarified comments
Clarified comments.
Fixed a bug when patch order was unspecified for ruby 1.8.
Added configure flags for catalog and data pathes.
2bb42eb
@johnmcdonnell johnmcdonnell Latest xcode is 4.5.2 1311e64
@dimitri

That formula fails here:

==> Installing open-jade
==> Downloading http://downloads.sourceforge.net/project/openjade/openjade/1.3.2/openjade-1.3.2.tar.gz
## 100.0%
==> Downloading patches
## 100.0%
## 100.0%
## 100.0%
## 100.0%
## 100.0%
## 100.0%
## 100.0%
## 100.0%
## 100.0%
==> Patching
patching file Makefile.lib.in
patching file Makefile.prog.in
patching file config/ltmain.sh
patching file configure
Hunk #1 succeeded at 3063 with fuzz 1 (offset 186 lines).
Hunk #2 succeeded at 7907 (offset 72 lines).
Hunk #3 succeeded at 9365 (offset 79 lines).
patching file spgrove/GroveApp.h
patching file spgrove/GroveBuilder.cxx
patching file grove/Node.h
/usr/bin/patch: **** Only garbage was found in the patch input.
Error: Failure while executing: /usr/bin/patch -f -p0 -i 007-homebrew.diff
@adamv
Owner

Still needs to be squashed to a single commit

@adamv
Owner

Did not build for me:

==> make install
make install
/bin/sh /private/tmp/open-jade-i2D2/openjade-1.3.2/config/mkinstalldirs /Users/adamv/homebrew/Cellar/open-jade/1.3.2/lib
mkdir /Users/adamv/homebrew/Cellar/open-jade/1.3.2/lib
/bin/sh /private/tmp/open-jade-i2D2/openjade-1.3.2/libtool --mode=install config/install-sh -c  libogrove.la /Users/adamv/homebrew/Cellar/open-jade/1.3.2/lib
config/install-sh -c .libs/libogrove.0.0.1.dylib /Users/adamv/homebrew/Cellar/open-jade/1.3.2/lib/libogrove.0.0.1.dylib
/private/tmp/open-jade-i2D2/openjade-1.3.2/libtool[4440]: eval: line 1: config/install-sh: not found
make[2]: *** [install] Error 127
make[1]: *** [grove] Error 2
make: *** [install] Error 2
@mikemcquaid mikemcquaid commented on the diff
Library/Homebrew/macos/xcode.rb
@@ -23,7 +23,7 @@ def latest_version
when 10.6 then "3.2.6"
else
if MacOS.version >= 10.7
- "4.5.1"
+ "4.5.2"
@mikemcquaid Owner

This shouldn't be here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mikemcquaid
Owner

Closing until this builds

@mikemcquaid mikemcquaid closed this
@theirix theirix deleted the theirix:open-jade branch
@theirix theirix restored the theirix:open-jade branch
@theirix theirix referenced this pull request
Closed

New formula: OpenJade #23971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 6, 2012
  1. @theirix

    New formula for OpenJade

    theirix authored
    Formula for OpenJade (http://openjade.sourceforge.net), DSSSL
    SGML processor. Port is derived from MacPorts, uses all
    provided patches and one more patch about missing .la file.
  2. @theirix

    Fixed patch order, clarified comments

    theirix authored
    Clarified comments.
    Fixed a bug when patch order was unspecified for ruby 1.8.
    Added configure flags for catalog and data pathes.
Commits on Nov 20, 2012
  1. @johnmcdonnell @theirix

    Latest xcode is 4.5.2

    johnmcdonnell authored theirix committed
This page is out of date. Refresh to see the latest.
Showing with 88 additions and 1 deletion.
  1. +87 −0 Library/Formula/open-jade.rb
  2. +1 −1  Library/Homebrew/macos/xcode.rb
View
87 Library/Formula/open-jade.rb
@@ -0,0 +1,87 @@
+require 'formula'
+
+class OpenJade < Formula
+ url 'http://downloads.sourceforge.net/project/openjade/openjade/1.3.2/openjade-1.3.2.tar.gz'
+ homepage 'http://openjade.sourceforge.net'
+ sha1 '54e1999f41450fbd62c5d466002d79d3efca2321'
+
+ depends_on 'xmlcatmgr' => :build
+ depends_on 'open-sp' => :build
+
+ def patches
+ # MacPorts patches for building openjade at a modern os x
+ { :p0 => %W[
+ https://trac.macports.org/export/87593/trunk/dports/textproc/openjade/files/patch-Makefile.lib.in
+ https://trac.macports.org/export/87593/trunk/dports/textproc/openjade/files/patch-Makefile.prog.in
+ https://trac.macports.org/export/87593/trunk/dports/textproc/openjade/files/patch-ltmain.sh
+ https://trac.macports.org/export/87593/trunk/dports/textproc/openjade/files/patch-configure
+ https://trac.macports.org/export/87593/trunk/dports/textproc/openjade/files/patch-GroveApp.h
+ https://trac.macports.org/export/87593/trunk/dports/textproc/openjade/files/patch-GroveBuilder.cxx
+ https://trac.macports.org/export/87593/trunk/dports/textproc/openjade/files/patch-Node.h ] +
+ # Patch for building with clang compiler
+ %W[ https://raw.github.com/gist/3732794/7d0c7d269bbf9d93b394b52e68810615d9aa33cb/default-ctor.patch ] +
+ # Patch for correct handling libtool library
+ %W[ https://raw.github.com/gist/3732807/1400a70e6396f2c2f3d90a0ca1035e7a79ae8bd6/Makefile.prog.in.patch ]
+ }
+ end
+
+ def install
+ ENV.append 'CXXFLAGS', '-fno-rtti'
+
+ system "./configure", "--enable-http",
+ "--enable-html",
+ "--enable-mif",
+ "--disable-debug",
+ "--disable-dependency-tracking",
+ "--prefix=#{prefix}",
+ "--datadir=#{share}/sgml/openjade",
+ "--enable-default-catalog=#{share}/sgml/catalog",
+ "--enable-default-search-path=#{share}/sgml"
+
+ # Patch libtool because it doesn't know about CXX
+ inreplace 'libtool' do |s|
+ s.change_make_var! "CC", ENV.cc
+ s.change_make_var! "CXX", ENV.cxx
+ end
+
+ system "make"
+ system "make", "install"
+
+ # Install additional dsssl
+ subdir = 'sgml/openjade'
+ (share+subdir).mkpath
+ (share+subdir).install Dir['dsssl/*']
+
+ # Link additional catalogs to the root catalog
+
+ catalog_sgml = etc + 'sgml/catalog'
+ catalog_openjade = share + 'sgml/catalog'
+
+ # Create the root catalog file if it doesn't exist
+ (etc+'sgml').mkpath
+
+ if !File.file?(catalog_sgml)
+ system "xmlcatmgr -s -c #{catalog_sgml} create"
+ end
+
+ # Create the intermediate openjade catalog file
+ # in share/sgml/catalog and reference a root catalog from it.
+ if !File.file?(catalog_openjade)
+ system "xmlcatmgr -s -c #{catalog_openjade} create"
+ end
+
+ # Add the root catalog to openjade's intermediate catalog
+ begin
+ safe_system "xmlcatmgr -s -c #{catalog_openjade} lookup #{catalog_sgml}"
+ rescue ErrorDuringExecution
+ system "xmlcatmgr -s -c #{catalog_openjade} add CATALOG #{catalog_sgml}"
+ end
+
+ # Add openjade's catalog to the root catalog
+ begin
+ safe_system "xmlcatmgr -s -c #{catalog_sgml} lookup #{share}/sgml/openjade/catalog"
+ rescue ErrorDuringExecution
+ system "xmlcatmgr -s -c #{catalog_sgml} add CATALOG #{share}/sgml/openjade/catalog"
+ end
+ end
+end
View
2  Library/Homebrew/macos/xcode.rb
@@ -23,7 +23,7 @@ def latest_version
when 10.6 then "3.2.6"
else
if MacOS.version >= 10.7
- "4.5.1"
+ "4.5.2"
@mikemcquaid Owner

This shouldn't be here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
else
raise "Mac OS X `#{MacOS.version}' is invalid"
end
Something went wrong with that request. Please try again.