This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+1, this is very helpful when working on SGML documentation, particularly PostgreSQL. |
A little uncomfortable about adding something that requires LLVM, as Clang is Apple's compiler going forward. |
Unfortunately my previous efforts to update open-jade to compile with clang failed - very old code. Anyway I'll try to do this again. |
Please squash to a single commit for review, thanks. |
Can some other maintainers review this? I'm uncomfortable with the rescue blocks here. |
Formula for OpenJade (http://openjade.sourceforge.net), DSSSL SGML processor. Port is derived from MacPorts, uses all provided patches and one more patch about missing .la file.
Clarified comments. Fixed a bug when patch order was unspecified for ruby 1.8. Added configure flags for catalog and data pathes.
That formula fails here:
|
Still needs to be squashed to a single commit |
Did not build for me:
|
@@ -23,7 +23,7 @@ def latest_version | |||
when 10.6 then "3.2.6" | |||
else | |||
if MacOS.version >= 10.7 | |||
"4.5.1" | |||
"4.5.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be here.
Closing until this builds |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formula for OpenJade (http://openjade.sourceforge.net), DSSSL
SGML processor. Port is derived from MacPorts, uses all
provided patches and one more patch about missing .la file.
Port requires LLVM compiler, open-sp built with LLVM and
recently added xmlcatmgr.