Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Gradle: keep bat file(s) #16749

Closed
wants to merge 1 commit into from
Closed

Gradle: keep bat file(s) #16749

wants to merge 1 commit into from

Conversation

praseodym
Copy link
Contributor

While I like that Homebrew removes useless files like bat and cmd files, the gradle.bat file which is removed by the Gradle formula is actually used by several applications to recognise the Gradle installation folder.

One of these applications is Eclipse: it does not accept the Gradle path unless a gradle.bat file is present. Doing a touch gradle.bat is sufficient, but annoying, so I thought it'd be easier to just keep the distribution's bat file around.

@Sharpie Sharpie closed this in c259bda Dec 26, 2012
@Sharpie
Copy link
Contributor

Sharpie commented Dec 26, 2012

One of these applications is Eclipse: it does not accept the Gradle path unless a gradle.bat file is present.

That is... an oddly brittle check.

But on the other hand, having some .bat files around isn't going to hurt anything---especially since they are sandboxed in the libexec folder.

Pulled.

@praseodym
Copy link
Contributor Author

It checks for a few more things (see the source), but the only reason to check for a .bat files would be because it's cross-platform code.

Thanks for pulling!

@Sharpie
Copy link
Contributor

Sharpie commented Dec 26, 2012

the only reason to check for a .bat files would be because it's cross-platform code.

Yeah, but one would think that check would be restricted to the platform that requires it:

if ( running_on_windows ) {
  check_for_bat_files()
}

@praseodym praseodym deleted the gradle-bat branch December 26, 2012 18:44
dholm pushed a commit to dholm/homebrew that referenced this pull request Jan 14, 2013
Closes Homebrew#16749.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants