Conversation
Need to dereference the |
exit 1 | ||
if [ "$BREW_SYSTEM" = "darwin" ] | ||
then | ||
exec $BREW_DIRECTORY/brew $* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"$@"
instead of $*
Updated. |
Updated again to resolve (one) symlink. Think we should do either do the |
Let me know how this looks now when you get a chance. Thanks. |
On OS X we want to use a particular Ruby interpreter. On other systems we want to use the Ruby interpreter found in the path. I suggest the following. if [ "$BREW_SYSTEM" = "darwin" ]
then
exec "$BREW_DIRECTORY/brew.rb" "$@"
else
exec ruby -W0 "$BREW_DIRECTORY/brew.rb" "$@"
fi Cheers, |
@sjackman Do you see a use in having your own |
@MikeMcQuaid Not immediately, unless we go the monkey patch route, but I'm not convinced that's the best solution. |
I think some monkey patching would be a good idea but I'll try and get some of the stuff merged from your other pull where it makes sense. |
Updated. Split into two commits so Git's rename detection behaves properly and used @sjackman's changes. |
This allows us to force using the system Ruby on OSX but allow the development of Homebrew for Linux or Windows to not rely on OSX paths. Closes #17548.
Haven't tested it but the approach looks fine. |
@Sharpie @mistydemeo @mxcl Thoughts? |
Approved. FFR: making brew work on Linux is worth it IMO. Though making the formula in Library/Formula a tap will be a prerequisite for it working well on Linux. |
Pushed this. It may well destroy the universe so I'll watch out for that. |
This allows us to force using the system Ruby on OSX but allow the development of Homebrew for Linux or Windows to not rely on OSX paths. Closes Homebrew#17548.
To allow easier configuration for non-OSX platforms.
References #16344.