Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

liquidprompt 1.8 #25925

Closed
wants to merge 2 commits into from
Closed

liquidprompt 1.8 #25925

wants to merge 2 commits into from

Conversation

augmentedfourth
Copy link
Contributor

No description provided.

@MikeMcQuaid
Copy link
Member

Looks like /usr/local/Cellar/liquidprompt/1.8/bin/liquidprompt isn't an executable? Run brew audit after brew install and see if you can fix that up.

@augmentedfourth
Copy link
Contributor Author

It's not meant to be an executable, actually. It's meant to be sourced into your shell config (.bash_profile or similar), not run within your shell session. Version 1.7, which is currently live, is exactly the same.

@MikeMcQuaid
Copy link
Member

Let's install it somewhere other than bin in that case.

@augmentedfourth
Copy link
Contributor Author

Ok, I'm really confused here. In the tar.gz file, the 'liquidprompt' file is indeed executable (which is fine, but not necessary, as I mentioned). However, when I run bin.install 'liquidprompt' in the formula, it copies the script into the Cellar and makes it non-executable. When I have etc.install 'liquidprompt' in there instead, it copies the file to /usr/local/etc/liquidprompt and leaves it executable!

Why does it remove the execute permission when I run bin.install? This seems completely counter-intuitive to me, especially because the Formula Cookbook specifically says that the bin.install method runs chmod +x on a file you install in that way.

@MikeMcQuaid
Copy link
Member

Probably because it's missing a shebang. Just put it in e.g. share.

@augmentedfourth augmentedfourth deleted the liquidprompt-1.8 branch January 15, 2014 22:45
@augmentedfourth augmentedfourth restored the liquidprompt-1.8 branch January 16, 2014 17:51
@augmentedfourth
Copy link
Contributor Author

Sorry... accidentally deleted my fork branch; didn't mean to close it. Hopefully this can still be merged.

@MikeMcQuaid
Copy link
Member

Merged minus the all-caps bit; I think it's overkill and we can add something later if people have issues. Thanks!

@augmentedfourth augmentedfourth deleted the liquidprompt-1.8 branch January 16, 2014 18:12
ehershey pushed a commit to ehershey/homebrew that referenced this pull request Apr 4, 2014
@augmentedfourth @ehershey
liquidprompt 1.8
d6d9127 
Move liquidprompt script to share & notify in info.

Closes Homebrew#25925.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@augmentedfourth @MikeMcQuaid