This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Wireshark: Update dependencies #34133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recommend c-ares. Otherwise name resolution is done synchronously, which is excruciatingly slow when your capture file contains a sufficient number of unique addresses. Remove the PCRE dependency. We switched GRegex (glib's PCRE wrapper) a while back.
|
You might want to go further and make c-ares mandatory. A case could be made that it's at least as important as decryption support. |
|
Thanks! Can you add a (mandatory) openssl dependency as well? It looks like it's linking against the deprecated system version, which is why it's failing our post-build audit. |
|
Also, if you could nuke this:
|
I'm pretty sure --with-ssl (which triggers linking against libcrypto) can be removed. As I recall it's a leftover from the days when we used Net-SNMP. Most of our decryption support is handled by gcrypt and GNUTLS.
jacknagel
pushed a commit
that referenced
this pull request
Nov 15, 2014
I'm pretty sure --with-ssl (which triggers linking against libcrypto) can be removed. As I recall it's a leftover from the days when we used Net-SNMP. Most of our decryption support is handled by gcrypt and GNUTLS. Closes #34133. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommend c-ares. Otherwise name resolution is done synchronously, which is excruciatingly slow when your capture file contains a sufficient number of unique addresses.
Remove the PCRE dependency. We switched GRegex (glib's PCRE wrapper) a while back.