libxdg-basedir 1.2.0 (new formula) #35149
Conversation
Formula for the libxdg-basedir library which is an implementation of the XDG Base Directory specifications.
| "--prefix=#{prefix}" | ||
| system "make", "install" | ||
| end | ||
| end |
There was a problem hiding this comment.
Can this test be modified to do something more substantial than e.g. --version or --help? See cmake.rb for an example of an application formula with a good test and tinyxml2.rb for an example of a library formula with a good test. Thanks!
There was a problem hiding this comment.
I have added a test
|
@BrewTestBot test this please. |
|
Please fix the |
|
Issues should be fixed now |
| depends_on "libtool" => :build | ||
|
|
||
| def install | ||
| system "./autogen.sh", "--disable-dependency-tracking", |
There was a problem hiding this comment.
Is this always the case? There seems to be an autogen and a configure file in the upstream repo. What's stopping us using the configure script for stable builds?
There was a problem hiding this comment.
There is a configure.ac file in the repo but no configure file. So it is needed to run the autogen to generate the configure file.
There was a problem hiding this comment.
👍. It'd be nice of upstream to release tarballs with configure scripts pre-generated so we can drop the autotool deps, but I don't have an issue with this setup.
|
Can someone from @Homebrew/owners give their 👍 / 👎 here as it’s a new formula? |
|
Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! |
Formula for the libxdg-basedir library which is an implementation of the XDG Base Directory specifications.