-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Conversation
patch :DATA | ||
|
||
def install | ||
# Fix Perl build flags | ||
conf = build.head? ? "configure.ac" : "configure" | ||
inreplace conf do |s| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this a Mac- or Homebrew-specific patch? If it's not I can send it upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. It was added in 2009. It looks like it was intended to be Homebrew specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be good to try and either remove it or get it upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can build and run Irssi (with Perl stuff) without it, so I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference in output between patch and no patch is:
- -arch x86_64 -arch i386 -g -pipe -fno-common -DPERL_DARWIN -fno-strict-aliasing -fstack-protector -I/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE %
+ -g -pipe -fno-common -DPERL_DARWIN -fno-strict-aliasing -fstack-protector -I/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE
And:
- -arch x86_64 -arch i386 -fstack-protector -L/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE -lperl
+ -fstack-protector -L/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE -lperl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's trying to build universally unconditionally? I think superenv
will actually handle this for us now. Mind checking that out, @DomT4 (i.e. seeing if you remove the patch if it makes a universal binary)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem here:
checking build system type... x86_64-apple-darwin14.4.0
checking host system type... x86_64-apple-darwin14.4.0
~> file /usr/local/Cellar/irssi/0.8.17_2/bin/*
/usr/local/Cellar/irssi/0.8.17_2/bin/botti: Mach-O 64-bit executable x86_64
/usr/local/Cellar/irssi/0.8.17_2/bin/irssi: Mach-O 64-bit executable x86_64
@@ -21,7 +27,7 @@ class Irssi < Formula | |||
depends_on "openssl" => :recommended | |||
depends_on "dante" => :optional | |||
|
|||
# Fix Perl build flags and paths in man page | |||
# Make paths in man page Homebrew-specific |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you switch this to using an inreplace
instead (and ideally file an upstream issue to complain about configure
not processing this file correctly)? Thanks!
This looks 💯 now if Mike is happy too. |
Should I remove the description? |
👍, Thanks! |
No description provided.