Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

midnight-commander: Fix man invocation #42176

Closed
wants to merge 1 commit into from
Closed

Conversation

petere
Copy link
Contributor

@petere petere commented Jul 27, 2015

mc calls man -l to display man page files, which is not correct on OS X, so patch out the -l to make it work.

mc calls `man -l` to display man page files, which is not correct on OS
X, so patch out the `-l` to make it work.
@@ -28,6 +28,7 @@ def install
"--with-screen=slang",
"--enable-vfs-sftp"
system "make", "install"
inreplace libexec/"mc/ext.d/text.sh", "man -P cat -l ", "man -P cat "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please submit this patch to the upstream developers of this project and add a link to the upstream patch submission and explanation of why the patch is needed in a comment in the formula file. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping on this.

@petere
Copy link
Contributor Author

petere commented Aug 6, 2015

The upstream bug tracker is rejecting my ticket submissions as spam.

Meanwhile, I found a patch for the same issue in FreeBSD: https://svnweb.freebsd.org/ports/head/misc/mc/files/patch-misc__ext.d__text.sh.in?view=markup&pathrev=382039

@petere
Copy link
Contributor Author

petere commented Aug 7, 2015

Ah, my ticket made it: http://www.midnight-commander.org/ticket/3509

@MikeMcQuaid
Copy link
Member

@petere Good news. Can you please add a link to the upstream patch submission and explanation of why the patch is needed in a comment in the formula file. Thanks!

@DomT4
Copy link
Member

DomT4 commented Aug 28, 2015

@BrewTestBot test this please

@DomT4
Copy link
Member

DomT4 commented Aug 29, 2015

Added the URL in manually after merge. Merged in 49dca04, Thanks!

@DomT4 DomT4 closed this in 49dca04 Aug 29, 2015
@petere petere deleted the mc-man-l branch August 30, 2015 02:53
ybogdanov pushed a commit to ybogdanov/homebrew that referenced this pull request Sep 1, 2015
mc calls `man -l` to display man page files, which is not correct on OS
X, so patch out the `-l` to make it work.

Closes Homebrew#42176.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants