Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

PEGTL 1.1.0 #42337

Closed
wants to merge 1 commit into from
Closed

PEGTL 1.1.0 #42337

wants to merge 1 commit into from

Conversation

guoxiao
Copy link
Contributor

@guoxiao guoxiao commented Aug 1, 2015

No description provided.

@MikeMcQuaid
Copy link
Member

Given this is only a single header I wonder if it's more useful to have it in Homebrew or just have projects vendor it?

@guoxiao
Copy link
Contributor Author

guoxiao commented Aug 1, 2015

So we don't accept header-only library in homebrew now?

@guoxiao
Copy link
Contributor Author

guoxiao commented Aug 1, 2015

Given this is only a single header

It's a header pegtl.hh and a folder of many headers.

@MikeMcQuaid
Copy link
Member

So we don't accept header-only library in homebrew now?

I haven't decided either way; I'm waiting for other maintainers to give their thoughts.

@DomT4
Copy link
Member

DomT4 commented Aug 1, 2015

What is the upstream Makefile intended to do, and why aren't we using it, out of curiosity?

@guoxiao
Copy link
Contributor Author

guoxiao commented Aug 1, 2015

@DomT4 The upstream Makefile is used by travis-ci to build all examples and unittests.

@DomT4
Copy link
Member

DomT4 commented Aug 1, 2015

Alright.

I guess I'm not fundamentally opposed to header-only libraries in Homebrew, but I'm not sure how widely used they'll ever be.

@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

For future reference the preferred commit message format for new formulae is pegtl 1.1.0 (new formula).

oubiwann pushed a commit to lfe-support/homebrew that referenced this pull request Aug 7, 2015
Closes Homebrew#42337.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
oubiwann pushed a commit to lfe-support/homebrew that referenced this pull request Aug 7, 2015
Closes Homebrew#42337.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants