Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Remove references to bin/examples #43449

Closed
wants to merge 1 commit into from
Closed

Conversation

gabelevi
Copy link
Contributor

Flow used to stick some examples in the bin directory, but we stopped doing that as of v0.14.0 (facebook/flow@b904adf). However the homebrew formula was still referencing it and that would cause errors.

Fixes facebook/flow#765

@dunn
Copy link
Contributor

dunn commented Aug 31, 2015

Would it be possible to replace the test with another that checks the functionality a bit more than --version does?

@DomT4
Copy link
Member

DomT4 commented Sep 1, 2015

It'd be nice to try and use shell_output or pipe_output rather than backtics if possible as well.

@dunn
Copy link
Contributor

dunn commented Sep 1, 2015

FYI also

        Error: 2 problems in 1 formula
flow:
 * Dependency 'objective-caml' was renamed; use newname 'ocaml'.
 * Dependency 'objective-caml' was renamed; use newname 'ocaml'.

@gabelevi
Copy link
Contributor Author

gabelevi commented Sep 1, 2015

Sure, I'll address the feedback.

As for tests, I'll see what's available when brew test runs. If I have access to Flow's source code, I can probably just run make test. Otherwise, I'll see if I can do something simple like

mkdir test
cd test
flow init test
echo "var x: string = 123;" > test/test.js
flow check test
rm -r test

I think I can infer how to test this locally by looking at Jenkin's console log.

@DomT4
Copy link
Member

DomT4 commented Sep 1, 2015

You won't have access to anything in the buildpath - The testpath is a separate entity. You also don't need to create or remove top-level temporary directories inside test do; we handle that automatically.

@gabelevi gabelevi closed this Sep 1, 2015
@gabelevi gabelevi deleted the patch-3 branch September 1, 2015 23:31
@gabelevi gabelevi restored the patch-3 branch September 1, 2015 23:31
@gabelevi
Copy link
Contributor Author

gabelevi commented Sep 1, 2015

Whoops

@gabelevi gabelevi reopened this Sep 1, 2015
@gabelevi
Copy link
Contributor Author

gabelevi commented Sep 4, 2015

Can someone merge this? It should be good to go

@dunn
Copy link
Contributor

dunn commented Sep 4, 2015

Sorry for the delay! Could you squash into one commit, though? Thanks!

Flow used to stick some examples in the bin directory, but we stopped doing that as of v0.14.0 (facebook/flow@b904adf). However the homebrew formula was still referencing it and that would cause errors.
@gabelevi
Copy link
Contributor Author

gabelevi commented Sep 4, 2015

Squashed!

dunn pushed a commit to dunn/homebrew that referenced this pull request Sep 4, 2015
Flow used to stick some examples in the bin directory, but we stopped doing that as of v0.14.0 (facebook/flow@b904adf). However the homebrew formula was still referencing it and that would cause errors.

Closes Homebrew#43449.

Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
@DomT4
Copy link
Member

DomT4 commented Sep 5, 2015

Merged in 2cb9f9c. Thank you for your contribution to Homebrew, we appreciate it! 😺

@DomT4 DomT4 closed this in 2cb9f9c Sep 5, 2015
@gabelevi gabelevi deleted the patch-3 branch September 8, 2015 16:28
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants