This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
sbcl: new --with-source option #48999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
||
| if build.with? "sources" | ||
| system "cp", "-R", "contrib", prefix | ||
| system "cp", "-R", "src", prefix |
There was a problem hiding this comment.
The audit failure is for these lines:
Error: 2 problems in 1 formula
sbcl:
* Use the `cp` Ruby method instead of `system "cp"`
* Use the `cp` Ruby method instead of `system "cp"`
There was a problem hiding this comment.
You can use prefix.install %w[contrib src] instead.
|
Already commented in issue. Please fix if you got time. If not, will do it @ weekend myself. |
|
Instead of sticking these directly under |
|
They should be there to make other things easier. Consider them (optional) part of the LISP machine, not sources. |
dunn
added a commit
to dunn/homebrew-core
that referenced
this pull request
Apr 7, 2016
4 tasks
dunn
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Apr 7, 2016
Following https://github.com/gentoo/gentoo/blob/93ae4c5c3c7f88413fcc79fe77abcaf9c12337d3/dev-lisp/sbcl/sbcl-1.1.18-r1.ebuild#L173 Closes Homebrew/legacy-homebrew#48968. Closes Homebrew/legacy-homebrew#48999. Closes #110. Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note this is only part of solution, as you'll still need to add (sb-ext:set-sbcl-source-location "/usr/local/Cellar/sbcl/1.3.2") to your local sbcl config (will require bit more time than I have ATM to fix, @ weekend most likely).