Install plists in FormulaInstaller, not build.rb

Build rb should only build!
Homebrew · Sep 17, 2012 · e09b32b · e09b32b
1 parent c29eb08
commit e09b32b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/Library/Homebrew/build.rb b/Library/Homebrew/build.rb
@@ -146,14 +146,6 @@ def install f
       f.prefix.mkpath
       f.install
 
-      # Install a plist if one is defined
-      unless f.startup_plist.nil?
-        unless f.plist_path.exist?
-          f.plist_path.write f.startup_plist
-          f.plist_path.chmod 0644
-        end
-      end
-
       # Find and link metafiles
       FORMULA_META_FILES.each do |filename|
         next if File.directory? filename

diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb
@@ -186,6 +186,7 @@ def finish
       check_PATH unless f.keg_only?
     end
 
+    install_plist
     fix_install_names
 
     ohai "Summary" if ARGV.verbose? or show_summary_heading
@@ -283,6 +284,14 @@ def link
     end
   end
 
+  def install_plist
+    # Install a plist if one is defined
+    if f.startup_plist and not f.plist_path.exist?
+      f.plist_path.write f.startup_plist
+      f.plist_path.chmod 0644
+    end
+  end
+
   def fix_install_names
     Keg.new(f.prefix).fix_install_names
   rescue Exception => e