streamripper 1.64.6 build failure with Lion/Xcode 4.3

[jwhitley]

Gist of build failure

The basic symptom appears to be that the streamripper build fails when it can't find mad.h, yet mad.h is clearly present in Homebrew's include directory. Digging in deeper, it looks like the -isystem /path/to/hb/include in CPPFLAGS in brew's environment is probably being ignored by clang. At least from clang's man page, the -isystem gcc-ism isn't documented. As such, this build failure appears to be a harbinger of a more widespread compatibility problem with the clang frontend.

FWIW, I tried forcing ENV.llvm in the formula, but essentially the same failures occured with llvm-gcc.

[jacknagel]

FWIW, clang does have -isystem:

$ clang -isystem
clang: error: argument to '-isystem' is missing (expected 1 value)

The compiler itself doesn't look at CPPFLAGS, it's up to the build system to pass its contents to the compiler properly. It wouldn't surprise me if the streamripper build is ignoring or munging CPPFLAGS, though.

As a quick hack, you might try adding ENV.append_to_cflags ENV.cppflags to the top of def install.

[jwhitley]

@jacknagel Brilliant. ENV.append_to_cflags ENV.cppflags works great as a quick fix. I have an older test system lying around which I think should work to test whether this hackfix is also acceptable to pre-Xcode 4.3 build systems.