This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Alternate "inreplacements" implementation #195
Comments
Yeah sweet, I think this is the best option yet. I find remakeflags a non-optimal name though still. Perhaps extend the file object and add something like:
I would stick with flags but they aren't flags as much as make variables. So we can do that with:
Where:
Also apologies for delay in applying your other patches, will try to do that now. |
I was also thinking of adding some extensions to string within that block, though hadn't gotten around to figuring out how to do that yet. |
See top two commits here: http://github.com/adamv/homebrew/commits/remake |
New string replace code has been merged in; recommend close this issue. |
lumaxis
pushed a commit
to lumaxis/homebrew
that referenced
this issue
Feb 17, 2015
* Recently llvm34 starts requiring isl 0.12+. Closes Homebrew#195.
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Max, since you're not keen on the "inreplacements"/"remakeflags" syntax, here's an alternate idea:
http://gist.github.com/253842
The text was updated successfully, but these errors were encountered: