Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Alternate "inreplacements" implementation #195

Closed
adamv opened this issue Dec 11, 2009 · 4 comments
Closed

Alternate "inreplacements" implementation #195

adamv opened this issue Dec 11, 2009 · 4 comments

Comments

@adamv
Copy link
Contributor

adamv commented Dec 11, 2009

Max, since you're not keen on the "inreplacements"/"remakeflags" syntax, here's an alternate idea:
http://gist.github.com/253842

@mxcl
Copy link
Contributor

mxcl commented Dec 12, 2009

Yeah sweet, I think this is the best option yet.

I find remakeflags a non-optimal name though still. Perhaps extend the file object and add something like:

f.gsub_make_var!

I would stick with flags but they aren't flags as much as make variables.

So we can do that with:

f.extend HomebrewMakeFlagExtension

Where:

module HomebrewMakeFlagExtension
  def gsub_make_var!
    #
  end
end

Also apologies for delay in applying your other patches, will try to do that now.

@adamv
Copy link
Contributor Author

adamv commented Dec 12, 2009

I was also thinking of adding some extensions to string within that block, though hadn't gotten around to figuring out how to do that yet.

@adamv
Copy link
Contributor Author

adamv commented Dec 17, 2009

See top two commits here: http://github.com/adamv/homebrew/commits/remake

@adamv
Copy link
Contributor Author

adamv commented Jan 13, 2010

New string replace code has been merged in; recommend close this issue.

lumaxis pushed a commit to lumaxis/homebrew that referenced this issue Feb 17, 2015
* Recently llvm34 starts requiring isl 0.12+.

Closes Homebrew#195.
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants