This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
make fix_install_names more robust #10291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a problem with the opencv formula
|
Approved. Thanks. |
|
Pulled. |
etehtsea
pushed a commit
to etehtsea/homebrew
that referenced
this pull request
Feb 22, 2012
fixes a problem with the opencv formula Closes Homebrew#10291. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Sharpie
pushed a commit
to Sharpie/homebrew
that referenced
this pull request
Jun 18, 2012
fixes a problem with the opencv formula Closes Homebrew#10291. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
snakeyroc3
pushed a commit
to snakeyroc3/homebrew
that referenced
this pull request
Dec 17, 2012
fixes a problem with the opencv formula Closes Homebrew#10291. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opencv formula does not seem to install correctly. The various libraries end up with install names of the type
@loader_path/lib/libfoo.dylib, and then fail to load each other. I worked around this by making fix_install_names a bit more robust: before fixing the recorded path for a dependent library, it checks if the new target exists; if it does not, it tries using the basename of the old path; if this still fails, an error is reported, instead of silently using a bad name.