Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Library/Homebrew/cmd/doctor.rb has a character that breaks the parser #10962

Closed
wants to merge 1 commit into from
Closed

Library/Homebrew/cmd/doctor.rb has a character that breaks the parser #10962

wants to merge 1 commit into from

Conversation

mtnygard
Copy link
Contributor

Looks like a "smart" apostrophe got checked in to a text block. This was causing errors like "invalid multibyte char".

@mxcl
Copy link
Contributor

mxcl commented Mar 15, 2012

Works here, why doesn't it work for you?

@mxcl mxcl closed this in 6a76f9b Mar 15, 2012
@mtnygard
Copy link
Contributor Author

I have no idea why it didn't work for me, but does for you.

@mxcl
Copy link
Contributor

mxcl commented Mar 15, 2012

Oh well, was just hoping to understand the issue. Pulled. Thanks.

@mistydemeo
Copy link
Member

I'm guessing your /usr/bin/ruby is a symlink to Ruby 1.9.x, @mtnygard. "invalid multibyte char" is a 1.9-specific error, since 1.8 doesn't really grok encodings. (More specifically: Ruby 1.9 strings have a builtin encoding, and Ruby will throw an exception if a string contains characters which are invalid in that string's encoding. That string was being interpreted as US-ASCII, and is not a valid ASCII character.)

We develop Homebrew against Ruby 1.8 since that's what comes with the OS, and don't recommend changing /usr/bin/ruby. Doesn't mean we don't fix 1.9 issues when they come up though. ;)

etehtsea pushed a commit to etehtsea/homebrew that referenced this pull request Mar 17, 2012
Closes Homebrew#10962.

Signed-off-by: Max Howell <max@methylblue.com>

Conflicts:

	Library/Homebrew/cmd/doctor.rb
staticfloat pushed a commit to staticfloat/homebrew that referenced this pull request Mar 26, 2012
Closes Homebrew#10962.

Signed-off-by: Max Howell <max@methylblue.com>
Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Jun 18, 2012
Closes Homebrew#10962.

Signed-off-by: Max Howell <max@methylblue.com>
snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
Closes Homebrew#10962.

Signed-off-by: Max Howell <max@methylblue.com>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants