Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

New Formula: Google Closure Linter. #11991

Closed
wants to merge 1 commit into from

Conversation

thughes
Copy link
Contributor

@thughes thughes commented May 1, 2012

Add Google's javascript lint utility.

@adamv
Copy link
Contributor

adamv commented May 1, 2012

I believe this is already in named closure.

@thughes
Copy link
Contributor Author

thughes commented May 1, 2012

I don't see closure. All I see is closure-compiler (https://github.com/mxcl/homebrew/blob/master/Library/Formula/closure-compiler.rb), which is different.

@adamv
Copy link
Contributor

adamv commented May 1, 2012

Ok.

@jacknagel
Copy link
Contributor

This was previously rejected: #7899

Though I don't know if things have changed, or if this formula works around the problem.

@thughes
Copy link
Contributor Author

thughes commented May 1, 2012

That formula looked like it was rejected because it required sudo. This one doesn't.

@thughes
Copy link
Contributor Author

thughes commented May 2, 2012

How about this? The only thing I'm not sure about is how to clean up the custom symlinks in site-packages on uninstall.

@gregrperkins
Copy link

Just tried this formula and got

Error: File exists - /usr/local/Cellar/closure_linter/2.3.5/libexec/python_gflags-2.0-py2.7.egg or /usr/local/lib/python2.7/site-packages/python_gflags-2.0-py2.7.egg

Probably I have installed closure linter before but something got corrupted...

@thughes
Copy link
Contributor Author

thughes commented May 30, 2012

Yep, that's the issue I was referring to with site-packages symlinks; the same thing happens if some other package has already installed that file. I guess I could add a check to see if a file or symlink by that name already exists.

For now if you manually remove that file it will work.

"--install-scripts=#{bin}"
site_packages = "#{HOMEBREW_PREFIX}/lib/#{which_python}/site-packages/"
File.symlink libexec+'python_gflags-2.0-py2.7.egg', site_packages+'python_gflags-2.0-py2.7.egg'
File.symlink libexec+'closure_linter-2.3.5-py2.7.egg', site_packages+'closure_linter-2.3.5-py2.7.egg'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you define site_packages as "#{lib}/#{which_python}/site-packages/", then they will be linked into the top-level but also cleaned up on uninstallation.

@adamv
Copy link
Contributor

adamv commented Jul 29, 2012

Please squash to a single commit for review

@adamv
Copy link
Contributor

adamv commented Oct 22, 2012

Needs to be Python version agnostic (can't assume Homebrew Python, needs to work with 2.6 or 2.7 depending on OS X version). Will accept an updated version for review.

@adamv adamv closed this Oct 22, 2012
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants