This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Allow requirements to specify env options #16733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add message to the DSL? Optional. |
|
Thought about it, but some messages interpolate instance variables so they would have to continue using the method form, so I didn't bother. |
This was referenced Dec 26, 2012
Closed
manphiz
added a commit
to manphiz/homebrew
that referenced
this pull request
Dec 28, 2012
| @@ -100,14 +100,16 @@ class MPIDependency < Requirement | |||
|
|
|||
| attr_reader :lang_list | |||
|
|
|||
| fatal true | |||
|
|
|||
| env :userpaths | |||
There was a problem hiding this comment.
... but when statisfied? is called, the build environment is not yet set up, so it is not satisfied :-(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements can now specify
env :userpaths,env :std, or any futureenvoptions that we add, though right now onlyenv :userpathsis respected.