Changed brew linkapps to use /Applications (not ~/Applications)

[iainbeeston]

This is a solution to #8699 based on the suggestion by @thecontrarian. Nobody else has actually made a pull request to change this, so I thought I'd give it a go.

[adamv]

I don't like this

[adamv]

Other maintainers: override me, or I'm rejecting this.

[MikeMcQuaid]

@adamv I'm not sure I understand what it's doing and why? Never used brew linkapps.

[adamv]

brew linkapps symlinks any .apps to your user's ~/Applications folder. This commit would change that to the system /Application folder, which I explicitly did not use in the first place.

[MikeMcQuaid]

Why did you not use that in the first place? Permissions/cleanliness?

[adamv]

Homebrew policy is to not mess with system folders, right? The only things I put in /Applications are Apple apps (Aperture) and things that insist on pkg-installing there (like Fusion).

[MikeMcQuaid]

Considering I don't use this tool I think it's basically down to your preference. I certainly think just changing the default will be confusing regardless of the merits.

[adamv]

I would accept a pull request that added a --system flag to linkapps that tried to use /Applications instead.

[demure]

I personally would prefer /Applications. In addition to a run time flag, I would find a permanent config flag desirable.

[iainbeeston]

See 2569641

[ELLIOTTCABLE]

I've gotta throw in a +1 here.

I understand the “don't modify the system” argument, which is great and all … but, if you think about it, the real spirit of that mandate (correct me if I'm wrong, @mxcl) can be better broken down into the following:

1. Don't do anything permanent, or that could seriously mess up the system.
2. Don't do anything that will later surprise the user.

Now, sure, /Applications is technically a system directory. But unlike throwing crap all around /bin or something, this is a “system” directory that the user(s) of the system interact with on a daily basis. For most systems, with only one[owner] user … and even for those with multiple[family / colleagues] users, the /Applications folder is visited (and modified) by everybody on a daily basis (so to speak).

Breaking it down using those two points above … while placing applications in the user's home-folder is certainly non-obtrusive (point 1), it's definitely later surprising to the user. (Who, other than @adamv, actually uses ~/Applications? I've been using OS X for a decade, and could definitely be described as a power-user, and I barely even realize that that exists. I've seen no other user, especially casual users / newbie developers, who are more likely to need/use Homebrew, make use of it. I'd love to see a poll, here.) Conversely, placing them in the normal /Applications folder is both non-obtrusive (despite breaking the letter of Homebrew's law against modifying ‘system’ directories) as well as non-surprising to the user (which the current operation is certainly not.)

---

My personal opinion: I'd like to see /Applications become the default for brew linkapps, with a --local flag or a per-user configuration option; and I'd like to see notification to the user of where applications have been installed, when running the command.

My suggestion: Whether or not my own desire is fulfilled here, I'd request that this issue be re-opened for discussion, and that some more users be polled in some fashion. I very very much doubt that very many would want to see ~/Applications chosen.

[vilhalmer]

+1 for @ELLIOTTCABLE's solution. The only time I ever interact with ~/Applications is when Steam puts symlinks to games in it without asking. Few OS X users really expect /Applications to be left alone, and putting things elsewhere probably does more damage than good, workflow-wise. A flag + per-user configuration option would be a great way to cater to both.

[adamv]

Take it to the mailing list; this is a 5 month old closed issue.

[mxcl]

I think it should be /Applications. Homebrew is meant to be useful.

Edit: Honestly, with hindsight, I'd make it so you didn't even need a further command to have .apps linked into /Applications. They are useless buried in a Cellar. If you want to install a .app then you need it somewhere useful. ~/Applications sucks.

Further: with true hindsight I would have prohibited .apps from Homebrew. I understand people want the ONE PACKAGE MANAGER TO RULE THEM ALL. But FFS we should have drawn a line at command line tools.

[mxcl]

I'd merge this but I don't know enough about the command, I don't use it. I am not willing to be the one who breaks things for other people.

[iainbeeston]

This was later resolved in this PR:

#18196

So I'd strongly recommend not merging this earlier version.

[ELLIOTTCABLE]

I'd say that it wasn't resolved, nor is it relevant; that's a flag to ask for one or the other, whereas I am here arguing the default functionality, and whether it's user-friendly in it's current design.

⁓ ELLIOTTCABLE — fly safe.
  http://ell.io/tt

On Wed, Sep 4, 2013 at 6:20 PM, Iain Beeston notifications@github.com
wrote:

This was later resolved in this PR:
#18196

So I'd strongly recommend not merging this earlier version.

Reply to this email directly or view it on GitHub:
#17643 (comment)

[demure]

I agree with @ELLIOTTCABLE that a user conf is still more desirable than just a flag, and /Applications is a better default. (side note, brew linkapps isn't in the man page so thats going to make it harder for someone to know about the flag...)

And for @mxcl, I would point out that programs closely tied to the cli are still in the community's interest (macvim, wireshark, gtk, etc). Do we have frivolous apps I haven't noticed?

[adamv]

Maiiiiiiiiling list. Guys this issue is closed which means it is a bad place to converse. Linkapps is a "unsupported" contrib command, so discuss on the mailing list or make a new pull request. Not here. Thank you.

[eddiemonge]

+1 on /Applications being the default

Sidenote, if you want things on the mailing list, it needs to be 1) easier to find and 2) easier to work with. This issue comes up higher in google results. In fact search for "homebrew mailing list" doesnt even give good results for it. Once I found it, I found its unusable: no search, sorting or filtering.

[adamv]

@eddiemonge I mostly don't want things to be in very old closed threads, I tend to "mute thread" when old bugs get new comments.

[eddiemonge]

very old closed threads are often good places to put things. it helps explain the reasoning behind something. however, having a way to have those reasons while keeping relevant information updated would be best.

[MikeMcQuaid]

@eddiemonge

Results seem pretty good to me.

I guess what Adam is politely saying is that if you want maintainers to actually listen to you, don't do it on closed threads.