New formula: Zopfli v1.0.0

[mathiasbynens]

This deprecates #18150 (and https://github.com/Homebrew/homebrew-headonly/pull/9).

[mistydemeo]

You don't need to close and submit a new pull request if you want to make a change to it. You can just force-push to the same branch on Github and it'll update automatically.

[mathiasbynens]

@mistydemeo I know, but the other pull request (#18150) isn’t mine, so that wouldn’t work. But thank you all the same :)

[mistydemeo]

Sorry, I somehow missed that the other pull request from you was in homebrew/headonly.

[mistydemeo]

No need for an explicit version, this is detected from the URL.

[mathiasbynens]

Thanks for the quick review, @mistydemeo! I’ve amended my commit.

[mathiasbynens]

@adamv

Use the full path to binaries in test methods: system "#{bin}/zopfli"

Done. Force-pushed the amended commit.

[mistydemeo]

Single quotes don't get string interpolation - need to use double quotes here.

[mathiasbynens]

Thanks 😊 Amended.

[mistydemeo]

Great! If you could report that to the author that would be great. It would be best if it did something like this:

diff --git a/makefile b/makefile
index 7e3272c..4d5488c 100644
--- a/makefile
+++ b/makefile
@@ -1,5 +1,7 @@
+CC := gcc
+
 make:
-   gcc src/zopfli/*.c -O2 -W -Wall -Wextra -ansi -pedantic -lm -o zopfli
+   $(CC) src/zopfli/*.c -O2 -W -Wall -Wextra -ansi -pedantic -lm -o zopfli

 debug:
-   gcc src/zopfli/*.c -g3 -lm -o zopfli
+   $(CC) src/zopfli/*.c -g3 -lm -o zopfli

So that we could specify our CC on the commandline.

[mathiasbynens]

Will do. Thank you so much for your patience and the many helpful comments!

Update: Done here.

[mistydemeo]

Pulled, thanks!

[alrra]

woo hoo! \o/

[mathiasbynens]

@mistydemeo Zopfli’s makefile has been updated: https://code.google.com/p/zopfli/source/browse/makefile There are now CC, CXX, CFLAGS, CXXFLAGS settings. Will this do?

[mistydemeo]

Looks good! We can make use of those when the next release is out. Thanks for taking this up with the author, I appreciate it.

[mathiasbynens]

Okay, I’ll ask the author to bump the version number and will update the Homebrew formula as soon as that happens. Thanks so much for the guidance, @mistydemeo!