Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Add Analog web analyzer tool. #21477

Closed
wants to merge 1 commit into from

Conversation

thaxter
Copy link
Contributor

@thaxter thaxter commented Jul 27, 2013

Re-submitting pull request #15016 as single commit to non-master branch.

depends_on 'libpng'

def install
system "make DEFS='-DLANGDIR=\\\"#{share}/analog/lang/\\\"'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you split this into multiple arguments to system you won't have to do all this escaping.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got the rest queued up, but this one is confusing as there's only
one argument. It has ruby quotes on the outside, then single quotes,
then double quotes inside, escaped because it works. In a shell it's:

make DEFS='-DLANGDIR="/foo-share/analog/lang"'

The escaping is due to
On Sat, 2013-07-27 at 09:34 -0700, Jack Nagel wrote:

In Library/Formula/analog.rb:

@@ -0,0 +1,25 @@
+require 'formula'
+
+class Analog < Formula

  • depends_on 'gd'
  • depends_on 'jpeg'
  • depends_on 'libpng'
  • def install
  • system "make DEFS='-DLANGDIR=\"#{share}/analog/lang/\"'"

If you split this into multiple arguments to system you won't have to
do all this escaping.


Reply to this email directly or view it on GitHub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. But if you use the multiple argument form, the arguments are passed as-is directly to make, bypassing shell expansion, so you can lose some of the escaping.

@adamv
Copy link
Contributor

adamv commented Jul 31, 2013

Ping.

@adamv
Copy link
Contributor

adamv commented Aug 30, 2013

@BrewTestBot test this please

@adamv adamv closed this in 8803323 Aug 30, 2013
handyman5 pushed a commit to handyman5/homebrew that referenced this pull request Oct 7, 2013
Closes Homebrew#21477.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants