Fixed libfdti include path, required to build properly

[zmetzing]

Fixed libfdti include path, required to build properly

[jacknagel]

It would be helpful to see they build failure and brew --config; it has built without this addition for others (and on the build bots).

[adamv]

Ping; can we see the build failure from your system?

Also note this should be squashed to a single commit, and pull requests should be made from non-master branches to avoid merge commits.

[zmetzing]

xxxxx@xxxxx.local:/usr/local% brew ls
xxxxx@xxxxx.local:/usr/local% brew update
Already up-to-date.
xxxxx@xxxxx.local:/usr/local% brew doctor
Your system is ready to brew.
xxxxx@xxxxx.local:/usr/local% brew --config
HOMEBREW_VERSION: 0.9.4
ORIGIN: https://github.com/mxcl/homebrew.git
HEAD: 9f478c5e6a26a91162edc3dbecea0a9f46783161
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CELLAR: /usr/local/Cellar
CPU: quad-core 64-bit ivybridge
OS X: 10.8.4-x86_64
Xcode: 4.6.3
CLT: 4.6.0.0.1.1365549073
LLVM-GCC: build 2336
Clang: 4.2 build 425
X11: 2.7.4 => /opt/X11
System Ruby: 1.8.7-358
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby
xxxxx@xxxxx.local:/usr/local% brew install --verbose libftdi
xxxxx@xxxxx.local:/usr/local% brew install --verbose libftdi
==> Installing dependencies for libftdi: cmake, libusb
==> Installing libftdi dependency: cmake
==> Downloading https://downloads.sf.net/project/machomebrew/Bottles/cmake-2.8.11.2.mountain_lion.bottle.tar.gz
Already downloaded: /Library/Caches/Homebrew/cmake-2.8.11.2.mountain_lion.bottle.tar.gz
==> Pouring cmake-2.8.11.2.mountain_lion.bottle.tar.gz
tar xf /Library/Caches/Homebrew/cmake-2.8.11.2.mountain_lion.bottle.tar.gz
==> Finishing up
ln -s ../Cellar/cmake/2.8.11.2/bin/ctest ctest
ln -s ../Cellar/cmake/2.8.11.2/bin/cpack cpack
ln -s ../Cellar/cmake/2.8.11.2/bin/cmakexbuild cmakexbuild
ln -s ../Cellar/cmake/2.8.11.2/bin/cmake cmake
ln -s ../Cellar/cmake/2.8.11.2/bin/ccmake ccmake
ln -s ../../../Cellar/cmake/2.8.11.2/share/man/man1/ctest.1 ctest.1
ln -s ../../../Cellar/cmake/2.8.11.2/share/man/man1/cpack.1 cpack.1
ln -s ../../../Cellar/cmake/2.8.11.2/share/man/man1/cmakevars.1 cmakevars.1
ln -s ../../../Cellar/cmake/2.8.11.2/share/man/man1/cmakeprops.1 cmakeprops.1
ln -s ../../../Cellar/cmake/2.8.11.2/share/man/man1/cmakepolicies.1 cmakepolicies.1
ln -s ../../../Cellar/cmake/2.8.11.2/share/man/man1/cmakemodules.1 cmakemodules.1
ln -s ../../../Cellar/cmake/2.8.11.2/share/man/man1/cmakecompat.1 cmakecompat.1
ln -s ../../../Cellar/cmake/2.8.11.2/share/man/man1/cmakecommands.1 cmakecommands.1
ln -s ../../../Cellar/cmake/2.8.11.2/share/man/man1/cmake.1 cmake.1
ln -s ../../../Cellar/cmake/2.8.11.2/share/man/man1/ccmake.1 ccmake.1
ln -s ../../Cellar/cmake/2.8.11.2/share/doc/cmake cmake
ln -s ../Cellar/cmake/2.8.11.2/share/cmake cmake
ln -s ../../Cellar/cmake/2.8.11.2/share/aclocal/cmake.m4 cmake.m4
ln -s ../../Cellar/cmake/2.8.11.2 cmake
ln -s ../Cellar/cmake/2.8.11.2 cmake
==> Summary
x  /usr/local/Cellar/cmake/2.8.11.2: 694 files, 34M
==> Installing libftdi dependency: libusb
==> Downloading http://downloads.sourceforge.net/project/libusb/libusb-1.0/libusb-1.0.9/libusb-1.0.9.tar.bz2
Already downloaded: /Library/Caches/Homebrew/libusb-1.0.9.tar.bz2
tar xf /Library/Caches/Homebrew/libusb-1.0.9.tar.bz2
==> ./configure --prefix=/usr/local/Cellar/libusb/1.0.9 --disable-dependency-tracking
./configure --prefix=/usr/local/Cellar/libusb/1.0.9 --disable-dependency-tracking
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... ./install-sh -c -d
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for gcc... cc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether cc accepts -g... yes
checking for cc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of cc... none
checking build system type... x86_64-apple-darwin12.4.0
checking host system type... x86_64-apple-darwin12.4.0
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/local/Library/ENV/4.3/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by cc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... no
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm
checking the name lister (/usr/bin/nm) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 196608
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... no
checking how to recognize dependent libraries... pass_all
checking for ar... ar
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm output from cc object... ok
checking for dsymutil... dsymutil
checking for nmedit... nmedit
checking for lipo... lipo
checking for otool... otool
checking for otool64... no
checking for -single_module linker flag... yes
checking for -exported_symbols_list linker flag... yes
checking for -force_load linker flag... yes
checking how to run the C preprocessor... cc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if cc supports -fno-rtti -fno-exceptions... yes
checking for cc option to produce PIC... -fno-common -DPIC
checking if cc PIC flag -fno-common -DPIC works... yes
checking if cc static flag -static works... no
checking if cc supports -c -o file.o... yes
checking if cc supports -c -o file.o... (cached) yes
checking whether the cc linker (/usr/bin/ld) supports shared libraries... yes
checking dynamic linker characteristics... darwin12.4.0 dyld
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking for windres... no
checking for inline... inline
checking whether cc understands -c and -o together... yes
checking operating system... Darwin/Mac OS X
checking poll.h usability... yes
checking poll.h presence... yes
checking for poll.h... yes
checking for nfds_t... yes
checking sys/timerfd.h usability... no
checking sys/timerfd.h presence... no
checking for sys/timerfd.h... no
checking whether TFD_NONBLOCK is declared... no
checking whether to use timerfd for timing... no (header not available)
checking for struct timespec... yes
checking for sigaction... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking for gettimeofday... yes
configure: creating ./config.status
config.status: creating libusb-1.0.pc
config.status: creating Makefile
config.status: creating libusb/Makefile
config.status: creating examples/Makefile
config.status: creating doc/Makefile
config.status: creating doc/doxygen.cfg
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
==> make install
make install 
Making install in libusb
  CC     libusb_1_0_la-core.lo
  CC     libusb_1_0_la-descriptor.lo
/bin/sh ../libtool --silent --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I..    -fvisibility=hidden -std=gnu99 -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow  -DLIBUSB_DESCRIBE=\"`git --git-dir "../.git" describe --tags 2>/dev/null`\" -g -O2 -c -o libusb_1_0_la-descriptor.lo `test -f 'descriptor.c' || echo './'`descriptor.c
  CC     libusb_1_0_la-io.lo
/bin/sh ../libtool --silent --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I..    -fvisibility=hidden -std=gnu99 -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow  -DLIBUSB_DESCRIBE=\"`git --git-dir "../.git" describe --tags 2>/dev/null`\" -g -O2 -c -o libusb_1_0_la-core.lo `test -f 'core.c' || echo './'`core.c
/bin/sh ../libtool --silent --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I..    -fvisibility=hidden -std=gnu99 -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow  -DLIBUSB_DESCRIBE=\"`git --git-dir "../.git" describe --tags 2>/dev/null`\" -g -O2 -c -o libusb_1_0_la-io.lo `test -f 'io.c' || echo './'`io.c
  CC     libusb_1_0_la-sync.lo
/bin/sh ../libtool --silent --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I..    -fvisibility=hidden -std=gnu99 -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow  -DLIBUSB_DESCRIBE=\"`git --git-dir "../.git" describe --tags 2>/dev/null`\" -g -O2 -c -o libusb_1_0_la-sync.lo `test -f 'sync.c' || echo './'`sync.c
brew: superenv removed: -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow -g -O2
brew: superenv removed: -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow -g -O2
brew: superenv removed: -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow -g -O2
brew: superenv removed: -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow -g -O2
  CC     libusb_1_0_la-darwin_usb.lo
/bin/sh ../libtool --silent --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I..    -fvisibility=hidden -std=gnu99 -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow  -DLIBUSB_DESCRIBE=\"`git --git-dir "../.git" describe --tags 2>/dev/null`\" -g -O2 -c -o libusb_1_0_la-darwin_usb.lo `test -f 'os/darwin_usb.c' || echo './'`os/darwin_usb.c
brew: superenv removed: -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow -g -O2
  CC     libusb_1_0_la-threads_posix.lo
/bin/sh ../libtool --silent --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I..    -fvisibility=hidden -std=gnu99 -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow  -DLIBUSB_DESCRIBE=\"`git --git-dir "../.git" describe --tags 2>/dev/null`\" -g -O2 -c -o libusb_1_0_la-threads_posix.lo `test -f 'os/threads_posix.c' || echo './'`os/threads_posix.c
brew: superenv removed: -Wall -Wundef -Wunused -Wstrict-prototypes -Werror-implicit-function-declaration -Wno-pointer-sign -Wshadow -g -O2
  CCLD   libusb-1.0.la
test -z "/usr/local/Cellar/libusb/1.0.9/lib" || .././install-sh -c -d "/usr/local/Cellar/libusb/1.0.9/lib"
test -z "/usr/local/Cellar/libusb/1.0.9/include/libusb-1.0" || .././install-sh -c -d "/usr/local/Cellar/libusb/1.0.9/include/libusb-1.0"
 /bin/sh ../libtool   --mode=install /usr/bin/install -c   libusb-1.0.la '/usr/local/Cellar/libusb/1.0.9/lib'
 /usr/bin/install -c -m 644 libusb.h '/usr/local/Cellar/libusb/1.0.9/include/libusb-1.0'
libtool: install: /usr/bin/install -c .libs/libusb-1.0.0.dylib /usr/local/Cellar/libusb/1.0.9/lib/libusb-1.0.0.dylib
libtool: install: (cd /usr/local/Cellar/libusb/1.0.9/lib && { ln -s -f libusb-1.0.0.dylib libusb-1.0.dylib || { rm -f libusb-1.0.dylib && ln -s libusb-1.0.0.dylib libusb-1.0.dylib; }; })
libtool: install: /usr/bin/install -c .libs/libusb-1.0.lai /usr/local/Cellar/libusb/1.0.9/lib/libusb-1.0.la
libtool: install: /usr/bin/install -c .libs/libusb-1.0.a /usr/local/Cellar/libusb/1.0.9/lib/libusb-1.0.a
libtool: install: chmod 644 /usr/local/Cellar/libusb/1.0.9/lib/libusb-1.0.a
libtool: install: ranlib /usr/local/Cellar/libusb/1.0.9/lib/libusb-1.0.a
----------------------------------------------------------------------
Libraries have been installed in:
   /usr/local/Cellar/libusb/1.0.9/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `DYLD_LIBRARY_PATH' environment variable
     during execution

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------
Making install in doc
make[2]: Nothing to be done for `install-exec-am'.
make[2]: Nothing to be done for `install-data-am'.
make[2]: Nothing to be done for `install-exec-am'.
test -z "/usr/local/Cellar/libusb/1.0.9/lib/pkgconfig" || ./install-sh -c -d "/usr/local/Cellar/libusb/1.0.9/lib/pkgconfig"
 /usr/bin/install -c -m 644 libusb-1.0.pc '/usr/local/Cellar/libusb/1.0.9/lib/pkgconfig'
==> Cleaning
rm: /usr/local/Cellar/libusb/1.0.9/lib/libusb-1.0.la
==> Finishing up
ln -s ../Cellar/libusb/1.0.9/include/libusb-1.0 libusb-1.0
ln -s ../../Cellar/libusb/1.0.9/lib/pkgconfig/libusb-1.0.pc libusb-1.0.pc
ln -s ../Cellar/libusb/1.0.9/lib/libusb-1.0.dylib libusb-1.0.dylib
ln -s ../Cellar/libusb/1.0.9/lib/libusb-1.0.a libusb-1.0.a
ln -s ../Cellar/libusb/1.0.9/lib/libusb-1.0.0.dylib libusb-1.0.0.dylib
ln -s ../../Cellar/libusb/1.0.9 libusb
ln -s ../Cellar/libusb/1.0.9 libusb
==> Summary
x  /usr/local/Cellar/libusb/1.0.9: 11 files, 420K, built in 8 seconds
==> Installing libftdi
==> Downloading http://www.intra2net.com/en/developer/libftdi/download/libftdi1-1.0.tar.bz2
Already downloaded: /Library/Caches/Homebrew/libftdi-1.0.tar.bz2
tar xf /Library/Caches/Homebrew/libftdi-1.0.tar.bz2
==> cmake .. -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/libftdi/1.0 -DCMAKE_BUILD_TYPE=None -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERBOSE_MAKEFILE=ON -Wno-dev
cmake .. -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/libftdi/1.0 -DCMAKE_BUILD_TYPE=None -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERBOSE_MAKEFILE=ON -Wno-dev
-- The C compiler identification is Clang 4.2.0
-- The CXX compiler identification is Clang 4.2.0
-- Check for working C compiler: /usr/local/Library/ENV/4.3/cc
-- Check for working C compiler: /usr/local/Library/ENV/4.3/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/local/Library/ENV/4.3/c++
-- Check for working CXX compiler: /usr/local/Library/ENV/4.3/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Build type: None
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE) 
-- Could NOT find LIBUSB (missing:  LIBUSB_INCLUDE_DIR) 
-- Could NOT find Boost
-- Could NOT find Doxygen (missing:  DOXYGEN_EXECUTABLE) 
-- Not generating API documentation
fatal: Not a git repository (or any of the parent directories): .git
-- Detected git snapshot version: unknown
-- Boost not found, won't build libftdi1++
-- Could NOT find SWIG (missing:  SWIG_EXECUTABLE SWIG_DIR) 
-- Found PythonLibs: /usr/lib/libpython2.7.dylib (found version "2.7.2") 
-- Found PythonInterp: /usr/bin/python (found version "2.7.2") 
-- Not building python bindings
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE) 
-- libConfuse not found, won't build ftdi_eeprom
-- Building example programs.
-- Could NOT find Boost
-- NOT building unit test (requires boost unit test framework)
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
LIBUSB_INCLUDE_DIR (ADVANCED)
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/src
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/src
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/examples
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/examples
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/examples
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/examples
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/examples
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/examples
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/examples
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/examples
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/examples
   used as include directory in directory /tmp/libftdi-5qwQ/libftdi1-1.0/examples

-- Configuring incomplete, errors occurred!
==> Configuration
HOMEBREW_VERSION: 0.9.4
HEAD: 9f478c5e6a26a91162edc3dbecea0a9f46783161
CPU: quad-core 64-bit ivybridge
OS X: 10.8.4-x86_64
Xcode: 4.6.3
CLT: 4.6.0.0.1.1365549073
X11: 2.7.4 => /opt/X11
==> ENV
HOMEBREW_CC: clang
MAKEFLAGS: -j4
CMAKE_PREFIX_PATH: /usr/local
CMAKE_INCLUDE_PATH: /usr/include/libxml2:/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_PATH: /usr/local/opt/libusb/lib/pkgconfig
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Library/ENV/pkgconfig/10.8
ACLOCAL_PATH: /usr/local/share/aclocal
OBJC: cc
PATH: /usr/local/Library/ENV/4.3:/usr/local/opt/cmake/bin:/usr/bin:/bin:/usr/sbin:/sbin

Error: libftdi did not build

[zmetzing]

BTW, those little steins of beer are cute, but github comment system doesn't like them:
"Unicode character above 0xffff detected ..."
If there isn't a preference to turn them off, it might be a good idea to do that when --verbose is enabled

[zmetzing]

"Also note this should be squashed to a single commit, and pull requests should be made from non-master branches to avoid merge commits."

Shows you how much I know about git. I'm an RCS/CVS guy, not hip to this new-fangled Linux source control. :-)

[adamv]

It looks like libfdti is missing a dependency on pkg-config.