Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Add SlimerJS 0.8.2 #22323

Closed
wants to merge 1 commit into from
Closed

Add SlimerJS 0.8.2 #22323

wants to merge 1 commit into from

Conversation

hanachin
Copy link

@hanachin hanachin commented Sep 5, 2013

No description provided.

@adamv
Copy link
Contributor

adamv commented Sep 10, 2013

We're not accepting new binary installs into homebrew core; https://github.com/Homebrew/homebrew-binary is available for this, or you can update the formula to compile from source.

@adamv adamv closed this Sep 10, 2013
@chrmoritz
Copy link
Contributor

@adamv: Then casperjs and phantomjs should also be moved there, because with the upcoming CasperJS 1.1 (currently in beta) casperjs can be used with either phantomjs or slimerjs (or both) and making an option to build casperjs with slimerjs would require tapping.

@adamv
Copy link
Contributor

adamv commented Sep 10, 2013

@chrmoritz open a pull request, or propose a new tap (for JS stuff?) that both of these could be moved to

@MikeMcQuaid
Copy link
Member

@adamv Or we can build them from source. I'll set that up for PhantomJS at some point.

@chrmoritz
Copy link
Contributor

@MikeMcQuaid : If you want to change to building them from source, you should really consider to provide bottles for them, because at least phantomjs and slimerjs are very time consuming builds.
As @adamv suggested, I created a PR to move them to homebrew/binary: Homebrew/homebrew-binary#18 .While creating this pr, I came across a issues which seems to be related to homebrew's taps implementation: sha1 on devel aren't checked in taps.

Edit:
In a earlier version of the phantomjs formula, it was build from source. But this has changed in c8ae355 in favor to not build the whole qt library (there was no bottle support in homebrew at this time) and use binaries provided by phantomjs instead, which only includes the necessary parts of qt with some patches. You can find the old discussion here: #11225
Edit2:
Ok, building phantomjs head from source seems to fail at least on my macbook air with the default build.sh: https://gist.github.com/chrmoritz/8df20cff3b904616315a

@MikeMcQuaid
Copy link
Member

@chrmoritz Yes, we'll bottle it.

@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants