Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

graphicsmagick: Fix some options #22929

Closed
wants to merge 4 commits into from
Closed

graphicsmagick: Fix some options #22929

wants to merge 4 commits into from

Conversation

chdiza
Copy link
Contributor

@chdiza chdiza commented Sep 29, 2013

Some of the imagemagick options recently imported aren't graphicsmagick options. Delete them and their dependencies.

Some have different names, so fix them.

@chdiza
Copy link
Contributor Author

chdiza commented Sep 29, 2013

See #22919 .

depends_on 'ghostscript' => :optional
depends_on 'webp' => :optional

depends_on 'libxml2' => :optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libxml2 comes with the system so I wonder if it'll use that version?

@chdiza
Copy link
Contributor Author

chdiza commented Sep 29, 2013

@MikeMcQuaid The configure script said it found libxml2 when I tested, without any brewed libxml2 present. However, otool -L /usr/local/bin/gm doesn't show libxml2. Maybe it shouldn't?

@chdiza
Copy link
Contributor Author

chdiza commented Sep 29, 2013

I tested again having brewed libxml2, and it still doesn't show up in otool -L.

@MikeMcQuaid
Copy link
Member

Perhaps a runtime dlopen. Sounds like we can remove the dependency as a result.

@MikeMcQuaid
Copy link
Member

@adamv @jacknagel Any ideas why we're getting a libtool dependency should be "depends_on 'libtool' => :build" audit failure with a :libltdl dependency (but only on 10.8/10.7)?

@MikeMcQuaid
Copy link
Member

Merged, thanks @chdiza!

@jacknagel
Copy link
Contributor

On 10.7/10.8 :libltdl turns into a plain libtool dep, but it doesn't have the :build flag (since it's not a build-time dep), but audit doesn't understand this. I've just been working around this in audit:

https://github.com/mxcl/homebrew/blob/3ab3c10968ae02796b7101b8147bb67ae3ecfa7d/Library/Homebrew/cmd/audit.rb#L156

@MikeMcQuaid
Copy link
Member

@jacknagel Cool, was just checking it wasn't my being stupid.

handyman5 pushed a commit to handyman5/homebrew that referenced this pull request Oct 7, 2013
Closes Homebrew#22919.
Closes Homebrew#22929.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants