This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Add support for pcap and tls support for sipp package #26708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| url 'http://downloads.sourceforge.net/project/sipp/sipp/3.4/sipp-3.3.990.tar.gz' | ||
| sha1 'b2637cb72556595253bbdd4a68cc974c9ac1d92e' | ||
|
|
||
| option 'pcap', 'Build with PCAP support' |
There was a problem hiding this comment.
Any reason not to include this by default (or always include it?)
There was a problem hiding this comment.
I didn't want to be presumptuous and change the established behavior
There was a problem hiding this comment.
Unless it takes dramatically longer to build let's just make it default.
There was a problem hiding this comment.
Should I add a no-pcap option incase someone doesnt want it ?
There was a problem hiding this comment.
Nah, they can always request/add it.
| sha1 'b2637cb72556595253bbdd4a68cc974c9ac1d92e' | ||
|
|
||
| option 'pcap', 'Build with PCAP support' | ||
| option 'openssl', 'Build with OpenSSL support' |
|
Please read the Ruby Style Guide and update this pull request's changes to conform to it. |
|
@MikeMcQuaid - ok, I just updated. Hope this is better. |
|
happy to see this 👍 |
spkane
pushed a commit
to spkane/homebrew
that referenced
this pull request
Mar 3, 2014
Closes Homebrew#26708. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
ehershey
pushed a commit
to ehershey/homebrew
that referenced
this pull request
Apr 4, 2014
Closes Homebrew#26708. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for building with PCAP support ( mojolingo/sippy_cup#44 (comment) )