This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Fix stack overflow in jgem command #26910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In jruby 1.7.10 (possibly earlier) the script in bin/gem simply calls bin/jgem. The jruby formula overwrites jgem with gem in the 'prefix with j' paragraph. This way the jgem script end up calling itself infinitely causing a stack overflow crash. This patch only overwrites if the target file does not yet exist; otherwise it removes the non-prefixed file.
| else | ||
| mv file, "j#{file}" | ||
| end | ||
| end |
There was a problem hiding this comment.
Make this less generic and just do what you need to do on the specific files with problems. It's quite hard to follow as-is. Also: needs a comment.
|
Better? |
|
@pepijnve Looks great, thanks. |
spkane
pushed a commit
to spkane/homebrew
that referenced
this pull request
Mar 3, 2014
In jruby 1.7.10 (possibly earlier) the script in bin/gem simply calls bin/jgem. The jruby formula overwrites jgem with gem in the 'prefix with j' paragraph. This way the jgem script end up calling itself infinitely causing a stack overflow crash. Closes Homebrew#26910. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
ehershey
pushed a commit
to ehershey/homebrew
that referenced
this pull request
Apr 4, 2014
In jruby 1.7.10 (possibly earlier) the script in bin/gem simply calls bin/jgem. The jruby formula overwrites jgem with gem in the 'prefix with j' paragraph. This way the jgem script end up calling itself infinitely causing a stack overflow crash. Closes Homebrew#26910. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In jruby 1.7.10 (possibly earlier) the script in bin/gem simply calls bin/jgem. The jruby formula overwrites jgem with gem in the 'prefix with j' paragraph. This way the jgem script end up calling itself infinitely causing a stack overflow crash.
This patch only overwrites if the target file does not yet exist; otherwise it removes the non-prefixed file.