Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Changed output type and exit code of upgrade for up-to date #27049

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 8 additions & 6 deletions Library/Homebrew/cmd/upgrade.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,20 @@ def upgrade
outdated = Homebrew.outdated_brews
exit 0 if outdated.empty?
else
outdated = ARGV.formulae.select do |f|
uninstalled = []
outdated = []
ARGV.formulae.each do |f|
if f.installed?
onoe "#{f}-#{f.installed_version} already installed"
false
oh1 "#{f}-#{f.installed_version} already installed"
elsif not f.rack.directory? or f.rack.subdirs.empty?
onoe "#{f} not installed"
false
uninstalled << f
else
true
outdated << f
end
end
exit 1 if outdated.empty?
exit 1 unless uninstalled.empty?
exit 0 if outdated.empty?
end

unless upgrade_pinned?
Expand Down