Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

sysdig 0.1.72 (new formula) #28116

Closed
wants to merge 4 commits into from
Closed

sysdig 0.1.72 (new formula) #28116

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15c0249
sysdig 0.1.72 (new formula)
juniorz Apr 3, 2014
5ef4308
that was my original formula
juniorz Apr 5, 2014
a73931e
enables c++11 features
juniorz Apr 5, 2014
c278219
trying 0.1.73 - fixes parallel build
juniorz Apr 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions Library/Formula/sysdig.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
require "formula"

class Sysdig < Formula
homepage "http://www.sysdig.org/"
url 'https://github.com/draios/sysdig/archive/0.1.72.tar.gz'
sha1 'c735c37da82022d22f77490b94f178ad98a1e6f6'

head 'https://github.com/draios/sysdig.git', :branch => 'development'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch should be 'master', that's what we use


depends_on :macos => :mavericks # depends on clang
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use fails_with with a version instead. Pretty sure 10.8 and 10.9 have the same version of Clang currently.

depends_on "cmake" => :build

def install
ENV.deparallelize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't ideal; has it been reported to upstream?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build works fine with make -jN, so no need to deparallelize


mkdir "build" do
system "cmake", "..", *std_cmake_args
system "make", "install"
end
end

test do
system "#{bin}/sysdig", "-h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this test be modified to do something more substantial then e.g. --version or --help? See cmake.rb for an example of a formula with a good test. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throwing a few ideas for some more tests:

  • running sysdig -cl and make sure that the LUA chisels are listed (since embedding LUAjit is probably the most critical part of the OSX build)
  • uploading a sysdig trace file somewhere (we can host it on download.draios.com if you want or just send a pull request and I'll put it in our repo) and run a simple chisel and test that the output is consistent with what you expect

end
end