Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

postgis 2.1.3 #29681

Closed
wants to merge 1 commit into from
Closed

postgis 2.1.3 #29681

wants to merge 1 commit into from

Conversation

kashif
Copy link
Contributor

@kashif kashif commented May 29, 2014

added recommended dependency on sfcgal see #29680

added recommended dependency on sfcgal
@dakcarto
Copy link
Contributor

Failed build bot report has no failed tests. ?

The addition of sfcgal is optional in the documented build requirements for 2.1. However, so is gdal and that's :recommended as well. Since the docs indicate the use of postgis.backend variable to switch to optionally use SFCGAL to override some GEOS functions, there should be no harm in having depends_on "sfcgal" => :recommended, especially since it adds extra 3D data support.

The only issue I see is for those users compiling. The extra cgal dependency adds compiling of boost; but, most users will be using bottles, so not a big issue.

@kashif I think you will want to use double quotes for newly added code to the formula, as per style guide.

@kashif
Copy link
Contributor Author

kashif commented May 29, 2014

thanks I will do that in the future!

@jacknagel
Copy link
Contributor

@BrewTestBot test this please

@jacknagel jacknagel closed this in bda3538 May 29, 2014
@kashif kashif deleted the postgis branch May 30, 2014 06:34
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants