Deprecate some contributions. #30749
Conversation
| @@ -361,4 +361,8 @@ def main(): | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| print """Warning: brew graph is unsupported and will be removed soon. | |||
There was a problem hiding this comment.
This message probably breaks .dot output.
There was a problem hiding this comment.
Good point. I should put it on stderr.
There was a problem hiding this comment.
fwiw I've ported this to ruby while working on the deps rewrite.
There was a problem hiding this comment.
I'd like to keep Jack's version in as a supported command, if there are no strong objections.
There was a problem hiding this comment.
Yup, that's cool with me. I guess I'm just interested in a bit of discussion on the initial PR description; perhaps let's make @jacknagel's version a core command.
+1. I don't like the handful that we've accept recently, they seem to be in a WIP state and it doesn't make sense for us to be responsible for them. In general I dislike external commands that use Homebrew internals, it makes it really hard to improve our own code if other people's code depends on things. For example, #30661 uses a lot of code that I don't consider to be "exposed", and it will break when things change in the future. The only interface that should be considered immovable is the CLI interface. |
|
Yup, I agree. We should have an actual public, documented (formula) API, add tests for that API and anything else is considered private and we can change at any minute.
|
This is just a starting point to start discussion. I think we have a few options with contributions: - Stop accepting them altogether and move the ones we need/use/support into core commands - Accept them on an unsupported basis and require they be added manually to the PATH - Actively support and fix bugs in them all
|
@jacknagel @adamv Addressed both comments. Let me know if you have any other problems or I'll merge this in a day or so. |
|
Fine with me. |
|
A few of these are listed in the External Commands page on the wiki. Maybe the page should note that they're deprecated. Or maybe just remove them… (btw, love homebrew! Thanks for all your hard work.) |
|
@jdhealy Done, thanks. |
Remove dependency on Brewfile as it appears that Homebrew is deprecating it.[1][1],[2][2] [1]: Homebrew/legacy-homebrew#30815 [2]: Homebrew/legacy-homebrew#30749
Homebrew is deprecating Brewfile. [issue][issue],[pull request][pr] [issue]: Homebrew/legacy-homebrew#30815 [pr]: Homebrew/legacy-homebrew#30749 Issue: #11
This is just a starting point to start discussion. I think we have a few options with contributions: - Stop accepting them altogether and move the ones we need/use/support into core commands - Accept them on an unsupported basis and require they be added manually to the PATH - Actively support and fix bugs in them all Closes Homebrew#30749. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
I don't know about the other ones, but I'm real sad that |
|
@soulcutter see #28657 |
Although looks like it'll be replaced at some point, keep an eye on it: Homebrew/legacy-homebrew#30815 Homebrew/legacy-homebrew#30749
This is just a starting point to start discussion. I think we have a
few options with contributions:
into core commands
manually to the PATH
Thoughts?