Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

qscintilla2 2.8.3 with designer plugin #31434

Closed
wants to merge 1 commit into from

Conversation

dakcarto
Copy link
Contributor

@dakcarto dakcarto commented Aug 7, 2014

Update QScintilla2 from 2.8.0 to 2.8.3

This is the last, I think, widely used Qt-dependent lib that builds/installs a Qt Designer plugin (others: qwt, qwtpolar). After this is pushed, can then focus on making a common plugins directory for qt and reset the Designer plugin symlinks to there (instead of qt's Cellar) for the above formulae, once completed/tested.

@dakcarto
Copy link
Contributor Author

dakcarto commented Aug 7, 2014

Hmm. Didn't have that test failure before. Now I do. Working on a fix.

@dakcarto
Copy link
Contributor Author

dakcarto commented Aug 8, 2014

Updated branch to test with build bot.

Waiting to hear back from developer if working patch is the correct approach.

if build.with? "python3"
depends_on "pyqt" => "with-python3"
else
depends_on "pyqt"
end

# Fix linking to C lib from Python module
patch :DATA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this bee submitted upstream? If so, please link to it, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qscintilla2, like pyqt and sip, doesn't have an issue tracker for the GPL-licensed releases. I have posted to the mailing list and am waiting for a reply.

@dakcarto
Copy link
Contributor Author

@MikeMcQuaid Removed patch, and updated the installed qscintilla2.prf instead, which was the appropriate fix. Should be good as is now.

Like making a common directory for Qt plugins, it might be good to put mkspecs also into a shared location. Then, formulae such as this can just install locally to their prefix and have their .prf files linked into a shared mkspecs directory. It would be defining the -datadir <dir> configure option.

@dakcarto
Copy link
Contributor Author

@MikeMcQuaid ping. Is ready to go, and no longer needs a patch.

@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants