Fontforge 20141014 #33174
Fontforge 20141014 #33174
Conversation
can we move this to |
| @@ -2,14 +2,10 @@ | |||
|
|
|||
| class Fontforge < Formula | |||
| homepage "https://fontforge.github.io" | |||
| url "https://github.com/fontforge/fontforge/archive/20141014.tar.gz" | |||
There was a problem hiding this comment.
Is this a stable release? It's not totally clear?
There was a problem hiding this comment.
Not sure either, tbh. I'll go upstream and ask. On the release page it states latest release but in this issue it states pre-release. 😕
There was a problem hiding this comment.
Yeh, I wouldn't rely on the GitHub releases pages as not everyone annotates prerelease tags properly.
There was a problem hiding this comment.
I've asked in the upstream issue. Hopefully shall know soon.
There was a problem hiding this comment.
Just to add a little more confusion, the announcement email:
We finally tagged what we consider to be a production-ready release (named 20141014) incorporating a large number of improvements that we've merged over the course of the last few months.
Our pre-release announcement covers most of the bases, but there is one more big thing that has delayed the big release and is finally ready (in my opinion at least).
There was a problem hiding this comment.
There hasn't been a release in 10 months, and the major feature - UFO format support - is reasonably ready, so this release is an official 'stable' release. I hope we'll make another one in about a month when all obvious defects are fixed. I've updated the release page title to say its stable.
There was a problem hiding this comment.
The lack of version number confuses me a bit here?
There was a problem hiding this comment.
Are you ditching semantic versioning @davelab6?
There was a problem hiding this comment.
We didn't really follow semver before, it was just 2.0.DATE... @adrientetar was against it prepending 2.0, but @JoesCat did it for the previous release (upstream discussion).
Maybe the next release should be 2.1.0 and we'll start with semver from then on...
There was a problem hiding this comment.
@MikeMcQuaid We could always tag this one internally as version 2.0?
Big 👍 on semver from me. Makes life a lot easier in terms of tracking updates & progress.
|
New issue opened upstream here. |
|
Pushed a new commit. The bot crashed before it even looked at it. Can one of the maintainers ask the bot to take another look at this please? Thanks in advance. |
|
Pushed a new commit. Better styling and added code comments explaining a couple of the changes to let me or anyone else maintaining this in future have a better idea of why certain things are needed, etc. This one should pass the bot. (Famous last words). |
Can we try and fix this? Move those files somewhere else and |
|
@MikeMcQuaid Yeah I noticed that failed the audit last night. I also discovered a new bug in Fontforge not picking up the |
|
New issue opened upstream on a newly discovered bug, different to the one I fixed locally last night. |
Version bump & appropriate changes for the Fontforge formula. This is another considerable update and consequently a lot has been moved around, updated, dependencies shifted, and so on. See the code comments for fuller details. Lilypond also receives a revision due to changes in the way Fontforge builds.
|
Alright. New commit pushed, fixing several bugs, including the audit one. I've also linked to the upstream PR I created to fix this there, and the upstream bug report for the |
|
Alright, Pending any sudden moves by upstream to fix the missing collab dylibs which I've temporarily made optional in the build we're good to go on this if everyone else is happy. If upstream merge in fixes to the issues I've opened there I'll create a later PR to restore those collab dependencies to |
Version bump & appropriate changes for the Fontforge formula. This is another considerable update and consequently a lot has been moved around, updated, dependencies shifted, and so on. See the code comments for fuller details. Lilypond also receives a revision due to changes in the way Fontforge builds. Closes Homebrew#33174. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Version bump & appropriate changes for the Fontforge formula. This is another considerable update and consequently a lot has been moved around, updated, dependencies shifted, and so on.
There may well be a bot issue with this update as Fontforge have decided to build a folder inside the bin folder, and the audit doesn’t like this.
Lilypond also receives a revision due to changes in the way Fontforge builds.