sdl: fixing dom is a moron #34721
sdl: fixing dom is a moron #34721
Conversation
Deals with the issue flagged up in [this commit](0d6d0213dc4cc406cdfd cb5ba742b361a0ab2210). Should have caught this at the time. I am an idiot.
|
If the maintainers prefer to revert the whole darn thing rather than deal with stupid inreplaces and undoing those inreplaces, I'm cool with that too. |
| if build.with? "tests" | ||
| ENV.prepend_path "PATH", "#{bin}" | ||
| # This is stupid but necessary. Blurgh. Otherwise, test building fails, even | ||
| # with various flags, prepending & pkg_config_path tinkering. | ||
| inreplace "#{bin}/sdl-config", "prefix=#{HOMEBREW_PREFIX}", "prefix=#{prefix}" |
There was a problem hiding this comment.
How about passing --with-sdl-prefix=#{prefix} to configure instead?
There was a problem hiding this comment.
Didn't work. Tried that, and --with-sdl-exec-prefix=#{prefix} and --with-sdl-prefix=#{HOMEBREW_PREFIX} --with-sdl-exec-prefix=#{prefix} in combination, and then I tried disabling the compile-time test, only for it to refuse to link to the libs, and then it kept refusing to link to the libs even with a flag in place.
|
Any remaining objection here? I'd either like to get this merged or revert my initial commit to resolve the breakage for people. Don't want to leave my initial broken commit in place any longer than necessary, really. |
|
Pushed. Would be good to work with upstream to work out an alternative approach to the |
|
(or at least file an issue) |
Deals with the issue flagged up in this commit. Should have caught this at the time. I am an idiot.