Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

groonga 4.0.8, remove autotools dependency #34995

Closed

Conversation

cosmo0920
Copy link
Contributor

No description provided.

@MikeMcQuaid
Copy link
Member

Can you explain this more please?

@cosmo0920
Copy link
Contributor Author

vendor/onigmo/Makefile.am patch which is removed in this pull request is force to update Makefile.am.
So, this update causes to be force to execute regenerate configure.
I've added just make instead.
This is because, Groonga-4.0.8's Makefile has trivial bug.

When just execute make install, it causes that libtool cannot find library libonig.la like this:

==> Patching
patching file lib/ii.c
patching file lib/grn.h
==> ./configure --prefix=/usr/local/Cellar/groonga/4.0.8 --with-zlib --disable-zeromq --with-mruby --without-libstemmer
==> make install
libtool: link: cannot find the library `../vendor/onigmo-source/libonig.la' or unhandled argument `../vendor/onigmo-source/libonig.la'
make[3]: *** [libgroonga.la] Error 1
make[2]: *** [install-recursive] Error 1
make[1]: *** [install] Error 2
make: *** [install-recursive] Error 1

But this error can avoid just add system "make" before system "make install"

system "autoreconf", "--force", "--install" is too exaggerated to fix problem.

@cosmo0920
Copy link
Contributor Author

I hope this answer your question.

@MikeMcQuaid
Copy link
Member

Ok, thanks!

@cosmo0920 cosmo0920 deleted the groonga-4.0.8-rmdep-autotools branch December 15, 2014 12:51
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants