PhantomJS 2.0.0

[MikeMcQuaid]

Closes #36240.

[MikeMcQuaid]

@DomT4 Apologies that you're going to hate me but I've pushed this as-is even although it seems to link against the system OpenSSL. I'm open to working out a better solution in a follow-up PR but wanted to get this in for now as we've got people clamouring for it.

[DomT4]

@MikeMcQuaid No worries. It's still a work in progress in terms of enforcing our OpenSSL, but there's exceptions to every rule. I promise not to hold it against you for this needing to be one of those exceptions for a while 😉

[MikeMcQuaid]

@DomT4 Well, it's a bit worse in that I didn't try particularly hard to resolve it because rebuilding from source is pain. If you want to give it a go at all: feel free 😉

[DomT4]

@MikeMcQuaid I seem to recall Phantom taking at least an hour to rebuild in the past, so I feel some hefty sympathy on that. Still, one of the perks of you being a maintainer is getting to ignore my OpenSSL ranting as desired 😉

[DomT4]

Doing a test rebuild of QT5, which PhantomJS contains, reveals some fun things. Don't know whether I spotted this at the time we dealt with Qt5 ages ago and we filed a report upstream on the inability to select OpenSSL. Looks like it's having the same Python on 10.6 problem and hooking directly into the SYSROOT and plucking headers and libs from that OpenSSL instead of anything else in the path:

/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/openssl/stack.h:95:5: note: 'sk_push' has been explicitly marked deprecated here

int sk_push(STACK *st,char *data) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;

^

ssl/qsslsocket_openssl_symbols.cpp:198:18: warning: 'sk_free' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]

DEFINEFUNC(void, sk_free, STACK *a, a, return, DUMMYARG)

^

ssl/qsslsocket_openssl_symbols_p.h:177:33: note: expanded from macro 'DEFINEFUNC'

ret q_##func(arg) { funcret func(a); }

^

[MikeMcQuaid]

Doh. Reckon we should just remove the (now redundant) openssl dependency for now then?

[DomT4]

I'm starting to hate things that insist on checking the sysroot first. But yeah, we should probably remove the openssl dep to make it clear it's not using our OpenSSL. A note similar to Qt5's with the same bug report links included might be an idea. I can tee up a PR if desired.