Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Rubinius bug fixes #3710

Closed
wants to merge 2 commits into from
Closed

Rubinius bug fixes #3710

wants to merge 2 commits into from

Conversation

josh
Copy link
Contributor

@josh josh commented Dec 26, 2010

  1. Unset RUBYLIB for Rubinius otherwise it aborts with this error:

    ERROR: Please unset RUBYLIB to configure Rubinius

  2. Remove conflicting aliases for "ruby", "irb", "rake", etc. I believe this was a regression introduced in 995b1c4.

@MikeMcQuaid
Copy link
Member

We generally don't try to fix users' environments for them. If Rubinius prints that, it's enough for me. Can you explain 2) a bit more please?

@josh
Copy link
Contributor Author

josh commented Dec 27, 2010

Homebrew takes a number of to setup a clean build environment to avoid build issues on peoples system. A good example is wiping CDPATH which interferes without alot of makefiles. https://github.com/mxcl/homebrew/blob/master/Library/Homebrew/extend/ENV.rb#L6-7

Whats annoying is that rubinius' setup just aborts if you have RUBYLIB set in your env. https://github.com/evanphx/rubinius/blob/master/Rakefile#L4-7

I understand not wanting to cover edge ENV variables but this is very specific to the rubinius build process.

An ideal solution would be spawning a clean subshell for all formula to build in. This is a bit more work though.

@MikeMcQuaid
Copy link
Member

I might fix the second but I won't change the first at the moment, can you please explain the second?

@josh
Copy link
Contributor Author

josh commented Dec 27, 2010

Prior to 995b1c4, binaries for ruby, gem, irb, etc were not linked in. Now they are clobbering my main ruby binary installed via the main ruby formula. We should remove them or namespace as done in the jruby formula. Namespacing seems silly when you can already access rubinius irb with rbx -S irb.

@MikeMcQuaid
Copy link
Member

Ok, thanks. Pulled the second. Please open an issue and/or another pull request about the first.

@josh
Copy link
Contributor Author

josh commented Dec 27, 2010

Follow up ticket #3715

@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants