This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Liblqr update #3727
Closed
Liblqr update #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeremyw pointed out that his builds failed: 6eb55e0#comments I found the same bug was reported on macports: http://trac.macports.org/ticket/19685 And solved with a patch: http://trac.macports.org/browser/trunk/dports/graphics/liblqr/files/patch-lqr__lqr_energy_priv.h The same modifications were added to the homebrew formula, which now builds succesfully. Unfortunately, I am not exactly sure *why* this solves the problem. Neither the MacPorts bug tracker nor the SVN commit message mention what was going wrong.
|
Nice work. Can you please try and submit this patch upstream and link in the formula to the ticket (rather than just specifying the number)? Thanks! |
|
Thanks, is there an easy way to modify commits submitted to a pull request, or do I just open up a new one? |
|
Just modify the formula, squash the changes and push -f |
|
Cool. |
nickstenning
pushed a commit
that referenced
this pull request
Apr 17, 2011
This is until we include the patch in #3727.
pagles
pushed a commit
to pagles/homebrew
that referenced
this pull request
Apr 29, 2011
This is until we include the patch in Homebrew#3727.
Sharpie
pushed a commit
to Sharpie/homebrew
that referenced
this pull request
Sep 12, 2012
This is until we include the patch in Homebrew#3727.
snakeyroc3
pushed a commit
to snakeyroc3/homebrew
that referenced
this pull request
Dec 17, 2012
This is until we include the patch in Homebrew#3727.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jeremyw reported build problems under 10.5, and could also verify that this patch solves them, see:
6eb55e0#comments