Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

bind: use https homepage #37320

Closed
wants to merge 2 commits into from
Closed

bind: use https homepage #37320

wants to merge 2 commits into from

Conversation

vszakats
Copy link
Contributor

@vszakats vszakats commented Mar 2, 2015

No description provided.

@MikeMcQuaid
Copy link
Member

@vszakats Perhaps a strange suggestion but: is there any chance you could watch this repo? It'd be helpful if you could suggest these changes on PRs as they come in rather than needing to be rebuilt each time. Thanks!

@vszakats
Copy link
Contributor Author

vszakats commented Mar 2, 2015

I can make a try and see how much the load is that way, though the current "pull" style seems easier to fit into occasional spots of free time near a computer. I've made an attempt recently to scan open PRs and left a batch of suggestions, but got just a low amount of follow-up.

I keep wondering if it'd be possible to automatize this at least to an extent at the audit stage. For url/mirror it often just means replacing ^http: with ^https: and verifying if it returns the same file as before.

@MikeMcQuaid
Copy link
Member

I guess I'm just wondering also what we're trying to achieve with making all these links https? I'm OK with audit rules being added but at some point I think it's worth stopping making dedicated changes just for URLs/homepages (and I'm wondering if that time is now).

@vszakats
Copy link
Contributor Author

vszakats commented Mar 2, 2015

My last impression was that this issue is important to this project, but if it isn't it won't cost me anything to stop it right now.

@MikeMcQuaid
Copy link
Member

@vszakats I think it's useful for the bigger packages but I think it does have diminishing returns. The problem is that our CI infrastructure (which is currently experiencing other issues) is not well equipped to test things like this that don't actually result in any e.g. code changes.

@vszakats
Copy link
Contributor Author

vszakats commented Mar 2, 2015

It's not trivial to tell what a bigger package is. Anyhow the best would be to automate as much as possible and catch the rest in PR review stage.

@vszakats vszakats changed the title bind: use https url and homepage bind: use https homepage Mar 2, 2015
@MikeMcQuaid
Copy link
Member

Sorry, I mean more popular packages.

@vszakats vszakats deleted the patch-1 branch March 4, 2015 01:07
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants