This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Use UNIXSocket to pass file descriptor #38434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rescue Errno::EAGAIN, Errno::EWOULDBLOCK, Errno::ECONNABORTED, Errno::EPROTO, Errno::EINTR | ||
| retry unless Process.waitpid(pid, Process::WNOHANG) | ||
| end | ||
| socket.send_io(write) unless socket.nil? |
There was a problem hiding this comment.
Should be able to do
begin
# ...
rescue # ...
# ...
else
socket.send_io(write)
endand skip the nil check here.
There was a problem hiding this comment.
Updated. Though socket.nil? is still required in Process.wait(pid)
This is a more standard way to pass fd in UNIX world. At the same time, it helps to remove a few hacks and simplifies the code in the sandbox.
|
Any more suggestion before I merge this? |
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jacknagel It works. Thanks for the tip.
Github doesn't allow me reopen the original PR after I run
push --force. So open a new one.