Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Fixing audit warnings #39061

Closed
wants to merge 5 commits into from
Closed

Fixing audit warnings #39061

wants to merge 5 commits into from

Conversation

mrjbq7
Copy link
Contributor

@mrjbq7 mrjbq7 commented Apr 25, 2015

Fixed a number of brew audit warnings.

  • Switch to https urls
  • Switch to ruby versions of mv, rm, touch, chmod
  • Fix wiki.freedesktop.org urls

Before:

Error: 304 problems in 238 formulae

After:

Error: 38 problems in 36 formulae

@DomT4
Copy link
Member

DomT4 commented Apr 25, 2015

Welp, this is going to set fire to the bots 😸. Homebrew doesn't usually accept such wide PRs, because when users do brew update they'll see a list of 300 formulae updated and most people panic in that situation. Maintainers here may welcome this PR in smaller chunks.

@jacknagel
Copy link
Contributor

Yes, please do break this up and submit in in smaller increments (spread out over a longer period of time). Thanks!

@jacknagel jacknagel closed this Apr 26, 2015
@jacknagel
Copy link
Contributor

Also, please avoid changing any gnome URLs, as I know others are working on these already.

@mrjbq7
Copy link
Contributor Author

mrjbq7 commented Apr 26, 2015

@jacknagel couple questions:

  1. How small, and over how many weeks would you like these changes to be spread? I would personally would rather rip the bandaid off quickly...

  2. The gnome URLs are changed to https because brew audit produced warnings and were fixed. Why is this bad?

https://github.com/Homebrew/homebrew/blob/master/Library/Homebrew/cmd/audit.rb#L311

@jacknagel
Copy link
Contributor

We have limited CI resources, and pull requests of this size block everything else from moving forward. I would say no more than 10 changed formula per PR, per day.

The gnome URLs are changed to https because brew audit produced warnings and were fixed. Why is this bad?

Because, as I said, others are already working on this and it will conflict with their work. Thanks!

@mrjbq7
Copy link
Contributor Author

mrjbq7 commented Apr 26, 2015

Oh, I misunderstood re: gnome.

Okay, I'll do smaller patches!

This was referenced Apr 26, 2015
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants