This repository has been archived by the owner. It is now read-only.

Minor fix for PortAudio formula #3926

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@paulchakravarti
Copy link

paulchakravarti commented Jan 17, 2011

Hi,

I made a minor change to the PortAudio formula to install 'pa_mac_core.h' into the include directory. This file is needed to compile PyAudio (Python binding) - with this change you should be able to just run 'pip install pyaudio' and it will compile the extension using the PortAudio brew files (otherwise fails with long error message).

This is my first commit so I hope this is the right format etc.

PS. Thanks for Homebrew - just moved across from MacPorts and it is a massive improvement.

Regards, PaulC

@adamv

This comment has been minimized.

Copy link
Contributor

adamv commented Jan 18, 2011

Looks good, but can you redo it to call "include.install" instead of .copy? ".install" is our preferred method here.

Thanks!

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jan 20, 2011

Need 'pa_mac_core.h' to compile PyAudio

Closed by 209566e.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jan 20, 2011

Pulled, thanks. In future, please squash down your commits into a single one when you add them to pull requests.

dtjm pushed a commit that referenced this pull request Apr 15, 2011

Need 'pa_mac_core.h' to compile PyAudio
Closes #3926.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012

Need 'pa_mac_core.h' to compile PyAudio
Closes Homebrew#3926.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

Need 'pa_mac_core.h' to compile PyAudio
Closes Homebrew#3926.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.