This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Minor fix for PortAudio formula #3926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but can you redo it to call "include.install" instead of .copy? ".install" is our preferred method here. Thanks! |
|
Need 'pa_mac_core.h' to compile PyAudio Closed by 209566e. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com> |
|
Pulled, thanks. In future, please squash down your commits into a single one when you add them to pull requests. |
dtjm
pushed a commit
that referenced
this pull request
Apr 15, 2011
Closes #3926. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Sharpie
pushed a commit
to Sharpie/homebrew
that referenced
this pull request
Sep 12, 2012
Closes Homebrew#3926. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
snakeyroc3
pushed a commit
to snakeyroc3/homebrew
that referenced
this pull request
Dec 17, 2012
Closes Homebrew#3926. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made a minor change to the PortAudio formula to install 'pa_mac_core.h' into the include directory. This file is needed to compile PyAudio (Python binding) - with this change you should be able to just run 'pip install pyaudio' and it will compile the extension using the PortAudio brew files (otherwise fails with long error message).
This is my first commit so I hope this is the right format etc.
PS. Thanks for Homebrew - just moved across from MacPorts and it is a massive improvement.
Regards, PaulC