sfml/csfml 2.3

[dunn]

The last update was a bit tricky (#35279) so let me know if there's anything I overlooked here.

[DomT4]

I knew I'd forgotten something. They've made major changes to the deps, see SFML/SFML#852 (comment).

[dunn]

From that thread:

Also on OS X we don't use the default OpenAL shipped by Apple.

Does that mean openal-soft for us?

[DomT4]

Looking at what upstream do for other platforms, yup.

[MikeMcQuaid]

csfml failing: http://bot.brew.sh/job/Homebrew%20Pull%20Requests/26400/version=yosemite/testReport/junit/brew-test-bot/yosemite/install_csfml/

[dunn]

They're recommending we wait for 2.3 of CSFML

[mantognini]

@dunn Thanks for updating those! :-)

[jacknagel]

rm_rf Dir["extlibs/*"] - ["extlibs/headers"]?

[dunn]

thanks!

[dunn]

Is an update warning at the top of each formula appropriate?

[MikeMcQuaid]

Is an update warning at the top of each formula appropriate?

👍

[dunn]

Linking CSFML fails because it has some of the same headers SFML has:

Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink include/SFML/Audio/AlResource.hpp
Target /usr/local/include/SFML/Audio/AlResource.hpp
is a symlink belonging to sfml. You can unlink it:
  brew unlink sfml

To force the link and overwrite all conflicting files:
  brew link --overwrite csfml

To list all files that would be deleted:
  brew link --overwrite --dry-run csfml

Possible conflicting files are:
/usr/local/include/SFML/Audio/AlResource.hpp -> /usr/local/Cellar/sfml/2.3/include/SFML/Audio/AlResource.hpp

Would it be safe to just remove CSFML's include/SFML directory, @mantognini?

[mantognini]

That's a strange error you got there... there is no AlResource.hpp in CSFML as far as I know.

[DomT4]

Linking CSFML fails because it has some of the same headers SFML has:

You seem to be using the same tarball for the two formulae? Were the two tarballs merged?

[dunn]

ahahahaha, my bad.

[DomT4]

Is this ready to ship? Not waiting on anything else now?

[dunn]

@mantognini, should we wait until the CSFML 2.3 source is available from http://www.sfml-dev.org/download/csfml/ and use that instead of the GitHub archive?

[mantognini]

For CSFML you can safely use GitHub zip archive, yes.

For SFML, we remove some files from it so it's safer to use the one from sfml-dev.org (currently we only remove .gitattributes but it used to be more than that -- don't know about the future though ;-))

[DomT4]

🚢'd in e2de038. Thanks @dunn @mantognini!

I removed the desc lines manually before merge as Mike requested we don't add any to existing formulae for now. Side note: Separate commits per formula (Inside the same PR) in this situation is preferable.

[dunn]

Good to know, thanks.