Added gupnp-tools 0.8.10 (new formula) #40483
Conversation
| "--prefix=#{prefix}" | ||
| system "make", "install" | ||
| end | ||
| end |
There was a problem hiding this comment.
Can a test be added to do something more substantial than e.g. --version or --help? See cmake.rb for an example of an application formula with a good test and tinyxml2.rb for an example of a library formula with a good test. Thanks!
There was a problem hiding this comment.
Difficult - as the formula is for a GUI tool. Suggestion?
|
Please fix the |
|
Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! For future reference the preferred commit message format for new formulae is |
|
Just saw this, isn’t it the same formula as the one in homebrew-x11? |
|
^ Yup, looks like it. We can remove it from It was probably only moved to X11 in the first place because GTK+3 originally had an X11 backend (It no longer does). Either that or the X11 dependency is actually optional, in which case it's cool to stay in the core as well. |
This formula was moved back to the core in #40483
Provides a collection of developer tools utilising GUPnP and GTK+.