Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

packer 0.8.1 #41351

Closed
wants to merge 2 commits into from
Closed

packer 0.8.1 #41351

wants to merge 2 commits into from

Conversation

lhoBas
Copy link
Contributor

@lhoBas lhoBas commented Jul 4, 2015

Since the creation of #41190, #41251 and #41237 regarding 0.8.0, packer 0.8.1 has been released.

This pull requests is based on #41237, updated to 0.8.1. Builds on my machine (Yosemite), go + mercurial from bottle. Test passed.

This was referenced Jul 4, 2015
@DomT4
Copy link
Member

DomT4 commented Jul 4, 2015

Failed to build. Same reason as in one of the other PRs I believe:

==> Getting dependencies...
package github.com/hashicorp/go-multierror
    imports github.com/mitchellh/reflectwalk
    imports github.com/aws/aws-sdk-go/aws
    imports github.com/aws/aws-sdk-go/aws/awserr
    imports github.com/aws/aws-sdk-go/aws/awsutil
    imports github.com/aws/aws-sdk-go/aws/credentials
    imports github.com/aws/aws-sdk-go/service/ec2
    imports github.com/dylanmei/winrmtest
    imports github.com/masterzen/winrm/soap
    imports github.com/masterzen/simplexml/dom
    imports github.com/masterzen/xmlpath
    imports github.com/satori/go.uuid
    imports github.com/masterzen/winrm/winrm
    imports github.com/nu7hatch/gouuid
    imports github.com/packer-community/winrmcp/winrmcp
    imports github.com/dylanmei/iso8601
    imports github.com/digitalocean/godo
    imports github.com/google/go-querystring/query
    imports github.com/tent/http-link-go
    imports golang.org/x/oauth2/jwt: /private/tmp/packer20150704-73657-10o2kpr/src/golang.org/x/oauth2 exists but /private/tmp/packer20150704-73657-10o2kpr/src/golang.org/x/oauth2/.git does not - stale checkout?
make: *** [bin] Error 1

@lhoBas
Copy link
Contributor Author

lhoBas commented Jul 4, 2015

😞

Only happens if brew fetch --retry --build-bottle --force packer is run before brew install --verbose --build-bottle packer, which explains why regular builds do succeed. (I was able to reproduce it locally now).

@lhoBas
Copy link
Contributor Author

lhoBas commented Jul 4, 2015

After rm -rf /Library/Caches/Homebrew/packer--* and updating the go_resource for golang.org/x/oauth2 to the latest commit, I can get packer to build + test passing (no brew fetch, just brew install).

I don't think I understand the difference between a local build and a bottle build regarding go_resources.

  • local build (no brew fetch, just brew install): builds + tests with current oauth2 rev + updated oauth2 rev as go_resource
  • bottle build (brew fetch + brew install): fails with current oauth2 rev + updated oauth2 rev as go_resource

Last two failures differ: current oauth2 rev fails as seen on the brew bot, updated oauth2 rev fails as seen on #41237 by @mistydemeo.

@lhoBas
Copy link
Contributor Author

lhoBas commented Jul 4, 2015

Right, got it after re-reading the comments. Updating the dependencies now.

Build passes now - should I squash? 😄

@mistydemeo
Copy link
Member

That's fine, I'd rather not push the job through the bots a second time - I squashed with a minor tweak. Thank you!

@mistydemeo mistydemeo closed this in 9583b6c Jul 4, 2015
@lhoBas lhoBas deleted the packer-0-8-1 branch October 6, 2015 09:14
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants