Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

mariadb 10.1.6 #42233

Closed
wants to merge 3 commits into from
Closed

mariadb 10.1.6 #42233

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ee2367
mariadb 10.1.6
makigumo Jul 29, 2015
ad54515
mariadb: patch for mroonga compilation with clang++
makigumo Jul 29, 2015
6fe222a
mariadb: add patch info
makigumo Jul 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 11 additions & 6 deletions Library/Formula/mariadb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,10 @@ class Mariadb < Formula
end

devel do
url "http://ftp.osuosl.org/pub/mariadb/mariadb-10.1.5/source/mariadb-10.1.5.tar.gz"
sha256 "af8788bfbb842338882e505612f86ef53a25968663a1519185ecf3de3b1efe83"
url "http://ftp.osuosl.org/pub/mariadb/mariadb-10.1.6/source/mariadb-10.1.6.tar.gz"
sha256 "492f28f0d7aee5bf0a0efd21c542ca4f291f349e66063695c5003df16e064959"
end

depends_on "cmake" => :build
depends_on "pidof" unless MacOS.version >= :mountain_lion
depends_on "openssl"

option :universal
option "with-tests", "Keep test when installing"
option "with-bench", "Keep benchmark app when installing"
Expand All @@ -30,6 +26,10 @@ class Mariadb < Formula

deprecated_option "enable-local-infile" => "with-local-infile"

depends_on "cmake" => :build
depends_on "pidof" unless MacOS.version >= :mountain_lion
depends_on "openssl"

conflicts_with "mysql", "mysql-cluster", "percona-server",
:because => "mariadb, mysql, and percona install the same binaries."
conflicts_with "mysql-connector-c",
Expand Down Expand Up @@ -80,6 +80,11 @@ def install
args << "-DPLUGIN_TOKUDB=NO"
end

# disable Mroonga on 10.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it need to be disabled?

(The conditional can also be made into a single line: args << "-DWITHOUT_MROONGA_STORAGE_ENGINE=1" if build.devel?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails with some messages like:

mariadb-10.1.6/storage/mroonga/vendor/groonga/lib/dat.cpp:191:3: error: cannot use 'try' with exceptions disabled

But I think I found a fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think I found a fix.

Great! If it's something that can be reported upstream, it'd be great if you could do that too.

if build.devel?
args << "-DWITHOUT_MROONGA_STORAGE_ENGINE=1"
end

args << "-DWITH_UNIT_TESTS=OFF" if build.without? "tests"

# Build the embedded server
Expand Down