This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
v8 4.4.63.31 #43428
Closed
v8 4.4.63.31 #43428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where is it listed what version corresponds to Chrome stable? |
| end | ||
|
|
||
| def install | ||
| # Bully GYP into correctly linking with c++11 | ||
| ENV.libcxx |
There was a problem hiding this comment.
Is it C++11 or libc++ you want? If it's the former, use ENV.cxx11, which will also set the appropriate flags when building with GCC.
There was a problem hiding this comment.
Pretty sure I meant the former and just had a 3am brain failure, Sorry 😩. Will re-do the build locally just to make sure.
There was a problem hiding this comment.
Fixed and pushed. Thanks for spotting this.
|
https://omahaproxy.appspot.com/ The first table on the page. Scroll to the far right and you'll see the V8 versions. Edit - You can also just do |
Closes #41091.
|
Oh, neat, thanks! |
ybogdanov
pushed a commit
to ybogdanov/homebrew
that referenced
this pull request
Sep 1, 2015
Closes Homebrew#41091. Closes Homebrew#43428. Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41091.