Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Added coturn formula #43845

Closed
wants to merge 2 commits into from
Closed

Added coturn formula #43845

wants to merge 2 commits into from

Conversation

bfanger
Copy link
Contributor

@bfanger bfanger commented Sep 12, 2015

A free open source implementation of TURN and STUN Server

Which is used for reliable (WebRTC) connections.

class Coturn < Formula
desc "Free open source implementation of TURN and STUN Server"
homepage "https://github.com/coturn/coturn"
url "http://turnserver.open-sys.org/downloads/v#{version}/turnserver-#{version}.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do this in Homebrew. The version should be inlined into the URL.

@bfanger
Copy link
Contributor Author

bfanger commented Sep 12, 2015

@DomT4 Ah, I misinterpreted the "version 4.4.5.4 is redundant with version scanned from URL" audit error.

I've updated the formula with inlined version into the url and removed the version property.

end

test do
system "turnadmin", "-l"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be system bin/"turnadmin", "-l", presuming the binary is in bin. We use full paths in testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed system "turnadmin", "-l" to system "#{bin}/turnadmin", "-l"

@bfanger
Copy link
Contributor Author

bfanger commented Sep 17, 2015

✅ Copy-pastable url
✅ Using absolute path in test do

Anything else?

Free open source implementation of TURN and STUN Server
@bfanger
Copy link
Contributor Author

bfanger commented Sep 30, 2015

Travis-CI failed due to github rate-limiting, you might want to add a HOMEBREW_GITHUB_API_TOKEN
to your travis environment to prevent this in the future:

http://docs.travis-ci.com/user/environment-variables/#Encrypted-Variables

Restart the job when github has calmed down, and you'll see that the formula builds just fine.

@DomT4
Copy link
Member

DomT4 commented Sep 30, 2015

We're aware of the Travis issues and working on them. Jenkins remains the primary CI at the moment.

@dunn
Copy link
Contributor

dunn commented Oct 3, 2015

Thanks for your patience! Merged in 22cccc4.

@dunn dunn closed this in 22cccc4 Oct 3, 2015
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants