Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

libtommath, libtomcrypt: new website for libtom project #43907

Closed
wants to merge 1 commit into from
Closed

libtommath, libtomcrypt: new website for libtom project #43907

wants to merge 1 commit into from

Conversation

apjanke
Copy link
Contributor

@apjanke apjanke commented Sep 14, 2015

STATUS: Don't merge yet; status of upstream sites is unclear.

Per their website, now at www.libtom.net:

This website is back, and libtom has found new maintainers.

mirror "https://distfiles.macports.org/libtomcrypt/crypt-1.17.tar.bz2"
sha256 "e33b47d77a495091c8703175a25c8228aff043140b2554c08a3c3cd71f79d116"
head "https://github.com/libtom/libtomcrypt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a .git on the end of this URL.

@apjanke
Copy link
Contributor Author

apjanke commented Sep 16, 2015

Repo URLs fixed.

brew install --HEAD libtomcrypt from this new URL is failing for me on 10.11, but it looks like the same error as the latest actual release in #43906.

@apjanke
Copy link
Contributor Author

apjanke commented Oct 5, 2015

Bump... can this be pulled in? Previous issues are fixed and checks pass.

@dunn
Copy link
Contributor

dunn commented Oct 6, 2015

@apjanke
Copy link
Contributor Author

apjanke commented Oct 6, 2015

D'oh! I'll check that out.

@apjanke
Copy link
Contributor Author

apjanke commented Oct 7, 2015

Known issue: #43906; it's failing on 10.10 and 10.11.

Can we just merge this website fix since it's not a regression, and deal with the build failure under the other issue?

@sjaeckel
Copy link

sjaeckel commented Oct 8, 2015

Not a good idea to update that, as the owner of libtom.net is currently not reachable and I don't know when this will change.
I hope to get libtom.org back up running.

@apjanke
Copy link
Contributor Author

apjanke commented Jan 25, 2016

How about now? It looks like libtom.net has the same contents as libtom.org now, and libtom.org is back online. Should we update this with links in to the new libtom.org site layout?

@sjaeckel
Copy link

Yes, libtom.net and libtom.org are functional now.
As I've only control over libtom.net you should probably go for that domain.
Download URLs are currently only from github.

@sjaeckel
Copy link

Regarding the site layout, yes that will be the one you want to update your links to.
You may ask youself why libtom.net is back - long story short, I was able to transfer it to me

apjanke referenced this pull request Jan 25, 2016
Closes #45063.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
@apjanke
Copy link
Contributor Author

apjanke commented Jan 25, 2016

Cool. I've revised and rebased this PR to use libtom.net and reflect the new site structure and GitHub releases. Works for me locally. Look good?

Download URLs from GitHub are fine for us, as long as they're for tagged releases, like you're doing here.

The new libtom.net web site is still referencing libtom.org, both in the site text (e.g. "Welcome to the LibTom Projects home here at libtom.org" on the front page) and in link URLs (e.g. in the navigation bar). Is there a repo for the web site where we can put bug reports/PRs for this?

If these new URLs work out, I'll try to add a couple little tests as part of this PR so the formulae pass our CI.

@MikeMcQuaid
Copy link
Member

@apjanke LGTM when 💚

@DomT4
Copy link
Member

DomT4 commented Jan 25, 2016

Would be good to pull bottles here when you merge. The libtomcrypt is currently lacking an El Cap one.

@apjanke
Copy link
Contributor Author

apjanke commented Jan 26, 2016

No bottles (at least for libtomcrypt), due to outstanding issue #43906, which breaks the build on 10.10 and 10.11. (Forgot about that when I was talking about the formulae passing CI.)

I think the thing to do is just merge this anyway and deal with the build failure separately: this URL fix will at least let brew-using devs download the files and attempt the build so they can debug and fix it.

@DomT4
Copy link
Member

DomT4 commented Jan 26, 2016

Ah, alright. Feel free in that case!

@apjanke apjanke closed this in ff52f57 Jan 26, 2016
@apjanke apjanke deleted the libtom-new-website branch January 26, 2016 03:27
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants