ode: Remove "--disable-demos" from default install and add the "--with-dem…

[sheim]

Requesting help for debugging, reference #43312.
Trying to build ode with the drawstuff library and demos.
Building manually works, resulting in an additional ode-0.13.1/drawstuff library, as well as a ode-0.13.1/ode/demo folder with several demos.

[MikeMcQuaid]

Should probably have a depends_on :x11 somewhere?

[DomT4]

Aye. depends_on :x11 if build.with? "drawstuff" I guess, however much we dislike if build.with? dependency statements.

[sheim]

Sorry, new to editing brew formulas. Added the line depends_on :x11 if build.with? "drawstuff" where all the other depends were. A drawstuff library folder still doesn't show up where it should compared to the manual install though. Any ideas?

[DomT4]

What are you expecting to see installed on top of the normal package? Just the demos?

[sheim]

So, when I compile from source with the demos option, it will build a drawstuff library (and put the folder in /ode-0.13.1/drawstuff) as well as a folder full of demos, (in /ode-0.13.1/ode/demos).

With brew, I'm finding neither of these folders, and other code that depends on the drawstuff library doesn't find it either so I'm assuming it's not built somewhere else and symlinked.

[dunn]

Compiling outside of Homebrew, make install doesn't install the demos directory, at least for me.

[sheim]

That's odd. Did you do ./configure --with-demos ?
Also, I just tried again, and both folders are there from the get-go (after
downloading, without compiling), just not built unless you configure with
demos.

I'm grabbing from the url mentioned in
the ode formula, is this just a reference perhaps?

On Sun, Sep 27, 2015 at 1:34 PM, Alex Dunn notifications@github.com wrote:

Compiling outside of Homebrew, make install doesn't install the demos
directory, at least for me.

—
Reply to this email directly or view it on GitHub
#44265 (comment).

[dunn]

OK, what's happening is it's installing the demos into buildpath/"ode/demo", instead of the specified prefix. So you'll have to install it manually after make install (and ideally submit a patch upstream to fix their Makefile).

[sheim]

Alright, tried messing around with it to no good end. Simply copying the drawstuff folder over doesn't work, as the makefile is then generated incorrectly with autoconf (paths etc. all off).
I'm a bit out of my depth here, so I'll leave it for now, and if I get time at some point, I'll see if I can adjust the makefile.ac for ode directly (I think it just needs to pass the --prefix option to the drawstuff makefile), that really seems like the more proper way of fixing this.

[dunn]

No problem. Feel free to leave this PR open, and thank you for contributing!