ssdb 1.9.2 #44552
ssdb 1.9.2 #44552
Conversation
felixbuenemann
commented
Oct 3, 2015
felixbuenemann
commented
- Update to 1.9.2
- Patch and install ssdb-cli
- Separate data directory for ssdb slave
- Fix ssdb-ins.sh script
felixbuenemann
force-pushed
the
ssdb-1.9.2
branch
from
798a67d
to
e1b3913
Compare
* Update to 1.9.2 * Patch and install ssdb-cli * Separate data directory for ssdb slave * Fix ssdb-ins.sh script
felixbuenemann
force-pushed
the
ssdb-1.9.2
branch
from
e1b3913
to
19af038
Compare
|
Have these patches been reported upstream? |
|
I don't really think it makes sense, because the patches adjust for the changes in directory structure done by the formula itself. The ssdb-ins.sh could probably be changed upstream to be able to work with both relative and absolute pidfile paths, but that still leaves the difference in the bin path. |
|
Since there's a |
|
The ssdb-ins.sh file is not generated by make. |
|
@dunn I agree that the amount of patching required to get this package to work fine with homebrews directory structure is a bit unhealthy and I'd be preferable to have the upstream build system improved to accommodate for that, but I really don't have the time to do that right now. So maybe we could live with the patches for the time being? |
|
@dunn Doesn't look too bad to me but feel free to disagree. |
|
@BrewTestBot test this please |
|
Right-o. Merged in 779726a, thank you @felixbuenemann! |
|
Thanks, Alex! |
